Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support object storage buckets in e2e test runner and script #1754

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Support object storage buckets in e2e test runner and script #1754

merged 1 commit into from
Apr 17, 2024

Conversation

rzetelskik
Copy link
Member

Description of your changes: This PR adds support for object storage buckets in e2e test runner and script.

Prerequisite for #1742

/priority critical-urgent
/kind feature
/hold
for https://github.com/scylladb/scylla-operator-release/pull/113, https://github.com/scylladb/scylla-operator-release/pull/123
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: This PR adds support for object storage buckets in e2e test runner and script.

Prerequisite for #1742

/priority critical-urgent
/kind feature
/hold
for https://github.com/scylladb/scylla-operator-release/pull/113, https://github.com/scylladb/scylla-operator-release/pull/123
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@rzetelskik rzetelskik mentioned this pull request Feb 27, 2024
Merged
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch 5 times, most recently from 40687ab to 7618b42 Compare March 1, 2024 11:32
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch 3 times, most recently from ce9a81c to 20b66ad Compare March 18, 2024 14:02
@rzetelskik
Copy link
Member Author

https://github.com/scylladb/scylla-operator-release/pull/113, https://github.com/scylladb/scylla-operator-release/pull/123 landed
/hold for https://github.com/scylladb/scylla-operator-release/pull/124
/cc zimnx tnozicka

@scylla-operator-bot scylla-operator-bot bot requested review from tnozicka and zimnx March 18, 2024 14:03
@rzetelskik rzetelskik changed the title [WIP] Support object storage buckets in e2e test runner and script Support object storage buckets in e2e test runner and script Mar 18, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2024
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch from 20b66ad to 4984e5f Compare March 18, 2024 14:23
@rzetelskik
Copy link
Member Author

#1694 (comment)
#1233 (comment)
/retest

tnozicka
tnozicka reviewed Mar 21, 2024
View reviewed changes
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch from 4984e5f to c1b4361 Compare March 26, 2024 10:45
zimnx
zimnx reviewed Mar 26, 2024
View reviewed changes
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch 2 times, most recently from 7808bd0 to ab938d6 Compare March 26, 2024 19:59
@rzetelskik rzetelskik requested a review from tnozicka March 26, 2024 22:59
tnozicka
tnozicka reviewed Mar 27, 2024
View reviewed changes
@rzetelskik rzetelskik force-pushed the object-storage-buckets branch from ab938d6 to ff52c22 Compare March 27, 2024 09:58
@rzetelskik rzetelskik requested a review from zimnx April 15, 2024 09:03
zimnx
zimnx approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updates, lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
tnozicka
tnozicka reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this planned to be tested? the logic seems to be unused

@rzetelskik rzetelskik force-pushed the object-storage-buckets branch 2 times, most recently from 207670c to f1c0836 Compare April 16, 2024 15:00
@rzetelskik
Copy link
Member Author

@tnozicka thanks, I replied to all of your comments

@rzetelskik rzetelskik requested a review from tnozicka April 16, 2024 15:00
@rzetelskik
Copy link
Member Author

Two known flakes:
#1028 (comment)
#1694 (comment)

Unrelated to these changes, so I'm not investigating.
/test images
/retest
to run against changes in CI

@rzetelskik
Copy link
Member Author

https://github.com/scylladb/scylla-operator-release/pull/177

/test images
/retest

tnozicka
tnozicka reviewed Apr 17, 2024
View reviewed changes
@rzetelskik
Copy link
Member Author

gcp permissions were fixed

/test images
/retest

@rzetelskik rzetelskik force-pushed the object-storage-buckets branch from f1c0836 to 98899e7 Compare April 17, 2024 13:56
@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest d0a112c link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip f1c0836 link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

Known manager flake - not investigating as it's unrelated.

@rzetelskik rzetelskik requested a review from tnozicka April 17, 2024 13:58
@rzetelskik
Copy link
Member Author

@tnozicka thanks, all changes should be applied now. Tests ran with updated CI and the vars were propagated to test runner.

tnozicka
tnozicka approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates!

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest d0a112c link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 98899e7 link true /test e2e-gke-parallel-clusterip
ci/prow/e2e-gke-parallel 98899e7 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

Known flake related to manager integration. Unrelated and we're already working on fixing this.

/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Apr 17, 2024 •
edited
Loading

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest d0a112c link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest d0a112c link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel 98899e7 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

Again, known manager flake. Unrelated.

/retest

@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 06038de into scylladb:master Apr 17, 2024
12 checks passed
@rzetelskik rzetelskik deleted the object-storage-buckets branch April 17, 2024 18:38
This was referenced May 7, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @zimnx @tnozicka