Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Scylla Manager E2E tests with backup and manual restore procedure #1742

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Extend Scylla Manager E2E tests with backup and manual restore procedure #1742

merged 1 commit into from
Jun 5, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Feb 22, 2024 •
edited
Loading

Description of your changes: This PR extends the existing manager backup integration test with actual object storage and manual restore procedure testing to verify their correctness.

Which issue is resolved by this Pull Request:
Resolves #1671

Prerequisites: #1850

/hold
for https://github.com/scylladb/scylla-operator-release/pull/113, https://github.com/scylladb/scylla-operator-release/pull/123, https://github.com/scylladb/scylla-operator-release/pull/124, #1754
/kind feature
/priority critical-urgent
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: WIP

Which issue is resolved by this Pull Request:
Resolves #1671

/hold
for https://github.com/scylladb/scylla-operator-release/pull/113, https://github.com/scylladb/scylla-operator-release/pull/123
/kind feature
/priority critical-urgent
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 2 times, most recently from e7210d5 to 5d257f3 Compare February 27, 2024 17:58
@rzetelskik rzetelskik mentioned this pull request Feb 27, 2024
Merged
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 6 times, most recently from 43dfe7d to 9239912 Compare February 28, 2024 00:56
@rzetelskik
Copy link
Member Author

/retest

@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 6 times, most recently from afddbf0 to ca632e8 Compare March 1, 2024 11:51
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch from ca632e8 to 4da4e62 Compare March 6, 2024 08:25
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 2 times, most recently from c1b76b3 to a05dc7a Compare March 6, 2024 18:49
@rzetelskik
Copy link
Member Author

/hold for #1795, #1752

@rzetelskik rzetelskik force-pushed the object-storage-e2e branch from 89f970f to 90e38b5 Compare May 21, 2024 16:17
@rzetelskik rzetelskik requested a review from zimnx May 21, 2024 16:30
zimnx
zimnx approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
tnozicka
tnozicka suggested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good, but this needs to be wired in a way that test considers setups that don't have object storage and runs gracefully there.

@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 4 times, most recently from 739d88c to 8a53ae2 Compare May 27, 2024 10:17
@rzetelskik rzetelskik requested a review from tnozicka May 27, 2024 10:18
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch 3 times, most recently from 12027df to af9e580 Compare May 31, 2024 13:36
tnozicka
tnozicka reviewed May 31, 2024
View reviewed changes
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2024
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch from af9e580 to 323d6f8 Compare June 4, 2024 14:03
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
@rzetelskik rzetelskik force-pushed the object-storage-e2e branch from 323d6f8 to da98156 Compare June 4, 2024 14:07
@scylla-operator-bot scylla-operator-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@rzetelskik rzetelskik requested a review from tnozicka June 4, 2024 14:11
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Jun 4, 2024 •
edited
Loading

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest a2e3c06 link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rzetelskik rzetelskik force-pushed the object-storage-e2e branch from da98156 to 0828bcf Compare June 4, 2024 16:00
tnozicka
tnozicka approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 3e45e81 into scylladb:master Jun 5, 2024
12 checks passed
@rzetelskik rzetelskik deleted the object-storage-e2e branch July 29, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Scylla Manager E2E with backup and manual restore procedure
3 participants
@rzetelskik @zimnx @tnozicka