-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and unify artifact collection in CI script #1911
Fix and unify artifact collection in CI script #1911
Conversation
74f1b57
to
c0049a4
Compare
c0049a4
to
c641d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks for fixing this
/hold
to check artifacts manually when the jobs finish
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c641d59
to
faf51ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm cancel
those logs should be on stderr :( |
faf51ee
to
fa4b0ba
Compare
/lgtm |
known manager flake |
Description of your changes: #1754 broke e2e artifacts collection in our CI. This PR fixes it by waiting for the e2e container to exit and then collecting the artifacts from its neighbour. It also removes the superfluous concurrency and unifies the collection of must-gather artifacts with e2e artifacts.
Which issue is resolved by this Pull Request:
Resolves #1910
/kind bug
/priority critical-urgent