Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and unify artifact collection in CI script #1911

Merged

Conversation

rzetelskik
Copy link
Member

Description of your changes: #1754 broke e2e artifacts collection in our CI. This PR fixes it by waiting for the e2e container to exit and then collecting the artifacts from its neighbour. It also removes the superfluous concurrency and unifies the collection of must-gather artifacts with e2e artifacts.

Which issue is resolved by this Pull Request:
Resolves #1910

/kind bug
/priority critical-urgent

@scylla-operator-bot scylla-operator-bot bot added the kind/bug Categorizes issue or PR as related to a bug. label May 7, 2024
@scylla-operator-bot scylla-operator-bot bot requested a review from tnozicka May 7, 2024 11:17
@scylla-operator-bot scylla-operator-bot bot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label May 7, 2024
@scylla-operator-bot scylla-operator-bot bot requested a review from zimnx May 7, 2024 11:17
@scylla-operator-bot scylla-operator-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@rzetelskik rzetelskik force-pushed the fix-artifacts-collection branch from 74f1b57 to c0049a4 Compare May 7, 2024 12:07
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2024
@rzetelskik rzetelskik force-pushed the fix-artifacts-collection branch from c0049a4 to c641d59 Compare May 7, 2024 12:26
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
thanks for fixing this

/hold
to check artifacts manually when the jobs finish

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@rzetelskik rzetelskik force-pushed the fix-artifacts-collection branch from c641d59 to faf51ee Compare May 7, 2024 13:40
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@tnozicka
Copy link
Contributor

tnozicka commented May 7, 2024

/lgtm cancel
I've tried to pick this into my PR but the exit code is incorrectly set even here

 + exit_code='I0507 12:39:52.777049       1 featuregate/feature_gate.go:249] feature gates: &{map[AllAlpha:true AllBeta:true AutomaticTLSCertificates:true]}
I0507 12:39:52.777228       1 tests/tests.go:30] maxprocs: Leaving GOMAXPROCS=[8]: CPU quota undefined 

those logs should be on stderr :(
https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1911/pull-scylla-operator-master-e2e-gke-serial/1787821240048685056#1:test-build-log.txt%3A524

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@rzetelskik rzetelskik force-pushed the fix-artifacts-collection branch from faf51ee to fa4b0ba Compare May 7, 2024 14:05
@tnozicka
Copy link
Contributor

tnozicka commented May 7, 2024

/lgtm
thanks

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel fa4b0ba link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

known manager flake
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit e6e36cf into scylladb:master May 7, 2024
12 checks passed
@rzetelskik rzetelskik deleted the fix-artifacts-collection branch May 7, 2024 16:07
@rzetelskik rzetelskik restored the fix-artifacts-collection branch May 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E artifacts are not collected in CI
2 participants