Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3cmd deploy on ubuntu-latest #9129

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

cwillisf
Copy link
Contributor

@cwillisf cwillisf commented Jan 8, 2025

Changes:

Reasoning:

GHA's ubuntu-latest tag recently moved from Ubuntu 22 to Ubuntu 24. GHA's ubuntu-24.04 image includes several versions of Python, but it defaults to Python 3.12 (and does not include Python 3.5). This caused our deploys to stop working for at least two reasons:

  1. We were installing pip via a script that was designed specifically for Python 3.5
  2. We were installing pip version 21.0.1, specifically
  3. We were then using pip to install s3cmd at version 2.3.0, specifically
    • This version of s3cmd is no longer compatible with Python 3.12

We fixed the pip installation issue with #9123, which exposed the s3cmd incompatibility.

For the sake of getting our in-progress deploy to work, we temporarily specified ubuntu-22.04 (see #9127).

The changes in this new PR move ci-cd.yml back to Unbuntu 24 by changing runs-on back to ubuntu-latest. We still use the setup-python action as introduced by #9123, but we now specify Python 3.12 exactly. We also get pip for free.

Upgrading s3cmd to version 2.4.0 adds Python 3.12 compatibility. Combined with Python 3.12 from above, this means our deploys should work again.

@cwillisf cwillisf requested a review from KManolov3 January 8, 2025 18:29
@cwillisf cwillisf changed the base branch from develop to master January 27, 2025 16:29
This should only take a few extra seconds, and might help catch problems
at PR time instead of at deploy time.
Using `ubuntu-22.04` was a temporary workaround
@cwillisf cwillisf force-pushed the hotfix/test-cwf-2025-01-08 branch from 2120d64 to 51cc73f Compare January 27, 2025 16:31
@cwillisf cwillisf merged commit 18b0994 into master Jan 28, 2025
3 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
@cwillisf cwillisf deleted the hotfix/test-cwf-2025-01-08 branch March 5, 2025 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant