Use setup python action #9123
Use setup python action #9123
Conversation
This should only take a few extra seconds, and might help catch problems at PR time instead of at deploy time.
| npm --production=false ci | ||
| mkdir -p ./test/results | ||
| - name: setup Python | ||
| uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Is this a Github supported version? (v5)
There was a problem hiding this comment.
Yep, 5.3.0 is the current version of actions/setup-python and v5 should pick that because semver. Also, Renovate will replace @v5 with @specific-hash once this gets merged.
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '^3.5' | ||
| - run: pip install s3cmd==2.3.0 |
There was a problem hiding this comment.
Longer term question: should we switch over to using AWS's python SDK and/or CLI for this?
There was a problem hiding this comment.
Yeah, I agree with that question. I'd expand it a bit:
- Is
s3cmdthe best way to deployscratch-www? (This is my version of your question) - If so, is
s3cmdthe only thing this workflow uses Python for? - If so, should we get/use
s3cmdsome other way, like through one of thes3cmdactions?
It could be that our current setup is the best option, but it's been long enough since we set this up that I think it deserves some investigation.
There was a problem hiding this comment.
Regarding the questions above - I don't have context on your previous considerations (and why s3cmd was chosen specifically) and I'm just starting to get acquainted with the deploy options;
from initial research though - AWS CLI does look like a simpler option that will look mostly the same in terms of workflow implementation - with the + that we won't have a python dependency.
Resolves:
Resolves the current build failure preventing both staging and production deploys.
Changes:
Before:
pipthat is compatible with Python 3.5, thenpipto installs3cmd==2.3.0After:
actions/setup-pythonto ensure availability of a version of Python that is compatible with v3.5, thenpipto installs3cmd==2.3.0Since these commands are relatively quick, I moved them earlier in the workflow. Also, while they're only necessary in the case of a deploy, running them even when not deploying means that if a PR breaks them, we'll know about it before we try to deploy.
Test Coverage:
Tested by manually running the GHA workflow on the branch. See also the checks on this PR.