Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3cmd deploy on ubuntu-latest #9129

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix s3cmd deploy on ubuntu-latest #9129

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d115f84
ci: install Python earlier in the ci-cd.yml GHA workflow
cwillisf Jan 7, 2025
abc9221
ci: use actions/setup-python
cwillisf Jan 7, 2025
6ca149a
ci: install Python and s3cmd even if not deploying
cwillisf Jan 7, 2025
3d2b2ef
ci: go back to unbuntu-latest
cwillisf Jan 8, 2025
51cc73f
ci: use exactly Python 3.12 and s3cmd 2.4.0
cwillisf Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ env:

jobs:
build-and-test-and-maybe-deploy:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
environment: >-
${{
(
Expand Down Expand Up @@ -56,10 +56,13 @@ jobs:
github.head_ref: ${{ github.head_ref }}
github.ref: ${{ github.ref }}
EOF
- name: setup
run: |
npm --production=false ci
mkdir -p ./test/results
- name: setup Python
uses: actions/setup-python@v5
with:
python-version: '3.12'
- run: pip install s3cmd==2.4.0
- run: npm --production=false ci
- run: mkdir -p ./test/results
- name: lint
run: npm run test:lint:ci
- name: build
Expand Down Expand Up @@ -89,12 +92,6 @@ jobs:
JEST_JUNIT_OUTPUT_NAME=localization-jest-results.xml npm run test:unit:jest:localization -- --reporters=jest-junit
npm run test:unit:tap -- --output-file ./test/results/unit-raw.tap
npm run test:unit:convertReportToXunit
- name: setup Python
if: ${{ env.SCRATCH_SHOULD_DEPLOY == 'true' }}
run: |
curl https://bootstrap.pypa.io/pip/3.5/get-pip.py -o get-pip.py
python3 get-pip.py pip==21.0.1
pip install s3cmd==2.3.0
- name: deploy
if: ${{ env.SCRATCH_SHOULD_DEPLOY == 'true' }}
run: npm run deploy
Expand Down
Loading