-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new year, new emoji 🚀 #4030
Conversation
--> | ||
* ✅ No, it does not introduce an observable change. | ||
* ⚠️ Yes, it does include an observable change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I thought this could be fixed with the variation selector character, but I guess not:
<-- with variation selector -->
⚠️
<-- without -->
⚠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also just replace the whole thing with "No, it does not introduce a breaking or observable change" vs "Yes, it does introduce a breaking or observable change"
For us, "observable" means "breaking" if it's in the context of component authors. I don't think there's much of a distinction between the two for us TBH.
I do feel like we have changes that are observable but not breaking though:
That said, I'm open to reconsidering whether we need these distinctions on every PR as an emoji + text. My 2 cents are that there's overlap, but there are slightly different decision paths happening:
|
Co-authored-by: Nolan Lawson <[email protected]>
Details
I don't like "✅ No". Also, it's slightly inconvenient that⚠️ displays in text-mode in the editor but emoji-mode in the actual post.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item