Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new year, new emoji 🚀 #4030

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore: new year, new emoji 🚀 #4030

merged 2 commits into from
Mar 12, 2024

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Mar 1, 2024

Details

I don't like "✅ No". Also, it's slightly inconvenient that ⚠️ displays in text-mode in the editor but emoji-mode in the actual post.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.
  • 🚨 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.
  • ⚠️ Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner March 1, 2024 21:41
-->
* ✅ No, it does not introduce an observable change.
* ⚠️ Yes, it does include an observable change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought this could be fixed with the variation selector character, but I guess not:

<-- with variation selector -->
⚠️

<-- without -->
⚠

Copy link
Contributor

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just replace the whole thing with "No, it does not introduce a breaking or observable change" vs "Yes, it does introduce a breaking or observable change"

For us, "observable" means "breaking" if it's in the context of component authors. I don't think there's much of a distinction between the two for us TBH.

@jye-sf
Copy link
Collaborator

jye-sf commented Mar 4, 2024

I do feel like we have changes that are observable but not breaking though:

That said, I'm open to reconsidering whether we need these distinctions on every PR as an emoji + text. My 2 cents are that there's overlap, but there are slightly different decision paths happening:

  • observable -> double check whether/how this could be breaking to someone. Consider how this should be communicated to customers through readme notes or docs.
  • breaking -> consider communication (overlaps with observable changes), rollout plan, and potential fallout.

@wjhsf wjhsf requested a review from nolanlawson March 11, 2024 16:18
@wjhsf wjhsf merged commit 4a882bb into master Mar 12, 2024
9 checks passed
@wjhsf wjhsf deleted the wjh/new-year-new-emoji branch March 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants