Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new year, new emoji 🚀 #4030

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore: new year, new emoji 🚀 #4030

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63c2d57
chore: new year, new emoji 🚀
wjhsf Mar 1, 2024
abef7c7
Update .github/PULL_REQUEST_TEMPLATE.md
wjhsf Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,43 @@
## Details


## Does this pull request introduce a breaking change?

<!--
Any change that can cause downstream consumers to fail qualifies as a breaking change.

Examples:
- Removing the code for a deprecated API.
- Adding a new restriction to the compiler which might result in a compilation failure for existing code.
- Changing the return type of a function in a non-backward compatible fashion.

Remove the incorrect item for the list.
Remove the incorrect item for the list.
-->
* ✅ No, it does not introduce a breaking change.
* 🚨 Yes, it does introduce a breaking change.

- 😮‍💨 No, it does not introduce a breaking change.
- 💔 Yes, it does introduce a breaking change.

<!-- If yes, please describe the impact and migration path for existing applications. -->

## Does this pull request introduce an observable change?

<!--
Observable changes are internal changes that can be observed by downstream consumers.
Such changes don't qualify as breaking changes because they don't impact any publicly defined
Observable changes are internal changes that can be observed by downstream consumers.
Such changes don't qualify as breaking changes because they don't impact any publicly defined
APIs.

Examples:
- Fixing a bug.
- Changing the invocation timing of a callback, for a callback that has no invocation timing
guarantee.

Remove the incorrect item from the list.
Remove the incorrect item from the list.
-->
* ✅ No, it does not introduce an observable change.
* ⚠️ Yes, it does include an observable change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought this could be fixed with the variation selector character, but I guess not:

<-- with variation selector -->
⚠️

<-- without -->
⚠


- 🤐 No, it does not introduce an observable change.
- 🔬 Yes, it does include an observable change.

<!-- If yes, please describe the anticipated observable changes. -->

## GUS work item

<!-- Work ID in text, if applicable. -->
Loading