-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add default exports to lwc
@W-13710298
#3997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits, but LGTM!
To be clear, this is only an observable change for npm package consumers, and only because new functionality is now exposed. So extremely low risk. |
Looks like you will have to pull in |
b4955c6
to
6ecc7d2
Compare
Details
Some of our packages have default exports, but
export * from 'some-package'
does not include the default export. In order to use a default export from anlwc
re-export, the default export must be handled explicitly.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-13710298