Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default exports to lwc @W-13710298 #3997

Merged
merged 11 commits into from
Feb 16, 2024
Merged

fix: add default exports to lwc @W-13710298 #3997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
66eb022
fix: include default exports in lwc re-exports
wjhsf Feb 14, 2024
5b2412b
test(lwc): validate default exports are re-exported; fixes #3605
wjhsf Feb 14, 2024
1c04a58
fix: remove stub test
wjhsf Feb 14, 2024
0bf9e28
test(lwc): skip testing index file; it's not a package
wjhsf Feb 16, 2024
6ecc7d2
fix: make tsconfig consistent with other packages
wjhsf Feb 16, 2024
d706409
chore: add comment explaining .cjs
wjhsf Feb 16, 2024
10b2fe6
test(lwc): validate that all dependencies have an export declared
wjhsf Feb 16, 2024
60ccfdc
test(lwc): use JSDOM so browser packages work
wjhsf Feb 16, 2024
9cef444
fix(tests): detect "default" default export and skip it
wjhsf Feb 16, 2024
15423fe
chore: use better test description
wjhsf Feb 16, 2024
ffafebb
chore: clarify comment
wjhsf Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: include default exports in lwc re-exports
  • Loading branch information
@wjhsf
wjhsf committed Feb 14, 2024
commit 66eb02240c2a66ada8fd60e10a19e25d372eecbc
3 changes: 2 additions & 1 deletion packages/lwc/babel-plugin-component.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export type * from '@lwc/babel-plugin-component';
export { default } from '@lwc/babel-plugin-component';
3 changes: 2 additions & 1 deletion packages/lwc/babel-plugin-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export * from '@lwc/babel-plugin-component';
export { default } from '@lwc/babel-plugin-component';
3 changes: 2 additions & 1 deletion packages/lwc/features.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export type * from '@lwc/features';
export { default } from '@lwc/features';
3 changes: 2 additions & 1 deletion packages/lwc/features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export * from '@lwc/features';
export { default } from '@lwc/features';
3 changes: 2 additions & 1 deletion packages/lwc/rollup-plugin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export type * from '@lwc/rollup-plugin';
export { default } from '@lwc/rollup-plugin';
3 changes: 2 additions & 1 deletion packages/lwc/rollup-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export * from '@lwc/rollup-plugin';
export { default } from '@lwc/rollup-plugin';
3 changes: 2 additions & 1 deletion packages/lwc/template-compiler.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export type * from '@lwc/template-compiler';
export { default } from '@lwc/template-compiler';
3 changes: 2 additions & 1 deletion packages/lwc/template-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/*
* Copyright (c) 2023, salesforce.com, inc.
* Copyright (c) 2024, salesforce.com, inc.
* All rights reserved.
* SPDX-License-Identifier: MIT
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
export * from '@lwc/template-compiler';
export { default } from '@lwc/template-compiler';