Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc. #28608

Closed
kliem opened this issue Oct 15, 2019 · 16 comments
Closed

CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc. #28608

kliem opened this issue Oct 15, 2019 · 16 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@kliem
Copy link
Contributor

kliem commented Oct 15, 2019

In Polyhedron the used abbreviation for representation is rep as in Hrep_generator etc.

Accordingly, this abbreviation is adopted for CombinatorialPolyhedron.

While we are at it we fix some instances of the typo representaion.

We add a deprecation warning for the keyword Vrepr of CombinatorialPolyhedron.__init__.

We remove a redefinition of a deprecated method (n_Hrepr of combinatorial face).

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 8fa61df

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28608
@kliem kliem added this to the sage-9.0 milestone Oct 15, 2019
@kliem

This comment has been minimized.

Sign in to view
@kliem
Copy link
Contributor Author

kliem commented Oct 16, 2019

Commit: 07d0742

@kliem
Copy link
Contributor Author

kliem commented Oct 16, 2019

Branch: public/28608

@kliem
Copy link
Contributor Author

kliem commented Oct 16, 2019

Changed dependencies from #28605 to #28605, #28616

@kliem

This comment has been minimized.

Sign in to view
@kliem
Copy link
Contributor Author

kliem commented Oct 16, 2019

Changed dependencies from #28605, #28616 to #28605, #28616, #28614

@kliem

This comment has been minimized.

Sign in to view
@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:5

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 27, 2020

Changed dependencies from #28605, #28616, #28614 to none

@kliem

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e91dcbatypos
2ce76f2deprecation warning for outdated keyword
8fa61dfremove redefinition of deprecated method alias

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 27, 2020

Changed commit from 07d0742 to 8fa61df

@LaisRast
Copy link
Contributor

Reviewer: Laith Rastanawi

@LaisRast
Copy link
Contributor

comment:8

It looks good to me.
I will wait for the patchbot to test in on 9.1.beta4

@kliem
Copy link
Contributor Author

kliem commented Feb 14, 2020

comment:9

Replying to @LaisRast:

It looks good to me.
I will wait for the patchbot to test in on 9.1.beta4

Bots are green, so I'll set it to positive review.

@vbraun
Copy link
Member

vbraun commented Feb 19, 2020

Changed branch from public/28608 to 8fa61df

@vbraun vbraun closed this as completed in 5cfbbfe Feb 19, 2020
This was referenced May 26, 2020
Closed
Closed
Closed
This was referenced Apr 5, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
4 participants
@embray @vbraun @kliem @LaisRast