CombinatorialPolyhedron: attributes, H -> facet_names; V -> Vrep

[kliem]

In order to be more meaningful, the name of the attribute _H of CombinatorialPolyhedron is changed to _facet_names. Likewise the corresponding method is renamed.

Also V is renamed Vrep.

Note that in #28608 we change the abbreviation from Vrepr to Vrep.

In CombinatorialFace we alter this change to ambient_Vrep and ambient_facets.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: ac4fd9d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28613

[kliem]

Dependencies: #28605

[kliem]

Commit: a366387

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source
e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv
a366387	H -> facet_names; V -> Vrep

[kliem]

Branch: public/28613

[kliem]

comment:5

I'm starting to doubt that _ambient_Vrep in CombinatorialFace is a good name for the Vrepresentation names of the polyhedron.

We will have ambient_Vrepresentation correspond to the elements of the Vrepresentation that define the face.

Then again in PolyhedronFace its ambient_dim for the dimension of the polyhedron?

Anyway, I don't think it's a good choice to have _ambient_Vrep and ambient_Vrepresentation mean two different things. What would be a good alternative for _ambient_Vrep?

[kliem]

comment:6

Waiting on #28605 and will then pull in the changes.

[kliem]

Changed commit from a366387 to aeab077

[kliem]

New commits:

aeab077

H -> facet_names; V -> Vrep

[kliem]

Changed branch from public/28613 to public/28613-reb

[kliem]

Changed dependencies from #28605 to none

[kliem]

comment:10

needs to be rebased

[kliem]

New commits:

ac4fd9d

H -> facet_names; V -> Vrep

[kliem]

Changed commit from aeab077 to ac4fd9d

[kliem]

Changed branch from public/28613-reb to public/28613-reb2

[tscrim]

comment:12

LGTM. It definitely is a better to have more meaningful name.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from public/28613-reb2 to ac4fd9d