CombinatorialPolyhedron: length_* to n_*

[kliem]

To make CombinatorialPolyhedron more consistent with Polyhedron we change the following names.

• length_Hrepr -> n_Hrepresentation
• length_Vrepr -> n_Vrepresentation

In FaceIterator:

• length_atom_repr -> n_atom_rep (note that CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc. #28608 changes repr to rep)

In CombinatorialFace:

• length_Vrepr -> n_ambient_Vrepresentation
• length_Hrepr -> n_ambient_Hrepresentation
  As both methods are public we keep the old methods with deprecation warnings.

As a follow up in #28615 we need to fix the alignment in src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 2ad0ec0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28614

[kliem]

Commit: 2bddb97

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source
e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv
2bddb97	length_* -> n_

[kliem]

Branch: public/28614

[sagetrac-git]

Changed commit from 2bddb97 to c030651

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c030651

deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

[kliem]

New commits:

c030651

deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

[kliem]

Changed keywords from none to polytopes, combinatorial polyhedron

[sagetrac-git]

Changed commit from c030651 to c0c5262

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c0c5262

altered the deprecation message to be the correct one for methods

[kliem]

comment:9

Actually due to merge conflict, this ticket depends on #28606 as well.

[kliem]

Changed dependencies from #28605 to #28605, #28606

[sagetrac-git]

Changed commit from c0c5262 to e6c672e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

dfbe2ad	Merge branch 'public/28607' of git://trac.sagemath.org/sage into public/28621
ed5518b	used CombinatorialPolyhedron to compute f_vector
9bdd005	give an error message for polytopes in some cases; removed incorrect example
acd671d	now we get a precice error message for inexact truncated dodecahedron
bf85a62	subsequent calls for f_vector fail if first attempt fails
dc99ea4	Merge branch 'public/28625' of git://trac.sagemath.org/sage into public/28605
9b5bcaa	applied changes of 28605 to new code from 28625
6fb97dc	Merge branch 'public/28605' of git://trac.sagemath.org/sage into public/28606
846f216	small fix in doc
e6c672e	merged in #28606; applied changes to new code from #28625

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2c039cc	length_* -> n_
a22010c	deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace
6b37686	altered the deprecation message to be the correct one for methods

[sagetrac-git]

Changed commit from e6c672e to 6b37686

[kliem]

comment:12

I rebased to #28606.

[kliem]

comment:13

Waiting on #28606.

[kliem]

Changed commit from 6b37686 to 39cc098

[kliem]

Changed dependencies from #28605, #28606 to none

[kliem]

New commits:

7acef4c	length_* -> n_
ade3dca	deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace
39cc098	altered the deprecation message to be the correct one for methods

[kliem]

Changed branch from public/28614 to public/28614-reb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f14e75b

missed a replacement

[sagetrac-git]

Changed commit from 39cc098 to f14e75b

[fchapoton]

comment:17

do not import anything from __future__ in pyx files

otherwise, looks good

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2ad0ec0

removed `from __future__` import in pyx files

[sagetrac-git]

Changed commit from f14e75b to 2ad0ec0

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:19

ok

[vbraun]

Changed branch from public/28614-reb to 2ad0ec0