Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doctests in combinatorial_polyhedron/conversions.pyx that depend on implementation details #30571

Closed
kliem opened this issue Sep 14, 2020 · 11 comments

Comments

@kliem
Copy link
Contributor

kliem commented Sep 14, 2020

We remove doctests that depend on implementation of the bitsets and exchange those by tests that check that conversion back and forth works correctly.

In addition we remove the deprecation warnings from #28608 in this file. Those functions aren't meant for public use anyway and the old names were exposed for a rather short period (sage 8.9 and sage 9.0).

CC: @jplab @LaisRast @tscrim

Component: geometry

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30571

@kliem kliem added this to the sage-9.3 milestone Sep 14, 2020
@kliem
Copy link
Contributor Author

kliem commented Sep 14, 2020

@kliem
Copy link
Contributor Author

kliem commented Sep 14, 2020

Last 10 new commits:

fc8124afix mistake
3e30d07add doctest functions for combinatorial_polyhedron/conversions.pyx
41ed120simplify doctest in list_of_faces
1529987simplify doctessts in polyhedron face lattice
7b134d5Merge branch 'u/gh-kliem/simplify_conversion_tests' of git://trac.sagemath.org/sage into u/gh-kliem/no_more_basic_access_2
072e200temporary commit
cba37e8temporary commit
0b41c77remove basic acces to bitsets
7a32286removed deprecated functions
af27e02remove doctests that rely on implementation details

@kliem
Copy link
Contributor Author

kliem commented Sep 14, 2020

Commit: af27e02

@tscrim
Copy link
Collaborator

tscrim commented Sep 25, 2020

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 25, 2020

Reviewer: Travis Scrimshaw

@kliem
Copy link
Contributor Author

kliem commented Sep 25, 2020

comment:3

Thank you.

@kliem
Copy link
Contributor Author

kliem commented Nov 27, 2020

comment:4

With #30528 gone, it's hard to make this work on it's own.

@kliem kliem removed this from the sage-9.3 milestone Nov 27, 2020
@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2020

Changed dependencies from #30528 to none

@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2020

Changed branch from u/gh-kliem/prepare_conversions_for_face_structure to none

@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2020

Changed author from Jonathan Kliem to none

@tscrim
Copy link
Collaborator

tscrim commented Nov 29, 2020

Changed commit from af27e02 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants