-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove doctests in combinatorial_polyhedron/conversions.pyx
that depend on implementation details
#30571
Labels
Comments
Last 10 new commits:
|
Commit: |
comment:2
LGTM. |
Reviewer: Travis Scrimshaw |
comment:3
Thank you. |
comment:4
With #30528 gone, it's hard to make this work on it's own. |
Changed dependencies from #30528 to none |
Changed branch from u/gh-kliem/prepare_conversions_for_face_structure to none |
Changed author from Jonathan Kliem to none |
Changed commit from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We remove doctests that depend on implementation of the bitsets and exchange those by tests that check that conversion back and forth works correctly.
In addition we remove the deprecation warnings from #28608 in this file. Those functions aren't meant for public use anyway and the old names were exposed for a rather short period (sage 8.9 and sage 9.0).
CC: @jplab @LaisRast @tscrim
Component: geometry
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/30571
The text was updated successfully, but these errors were encountered: