Trac #27627: Remove deprecated code in sage/structure

Remove code deprecated in #18555 (Sage 7.3) #24135, #24254, #24256,
#24363, #24614 (Sage 8.2)

URL: https://trac.sagemath.org/27627
Reported by: jdemeyer
Ticket author(s): Jeroen Demeyer
Reviewer(s): Frédéric Chapoton

src/sage/combinat/crystals/tensor_product.py

@@ -1016,9 +1016,3 @@ def _element_constructor_(self, *args, **options):
 
     class Element(CrystalOfTableauxElement):
         pass
-
-# deprecations from trac:18555
-from sage.misc.superseded import deprecated_function_alias
-TensorProductOfCrystals.global_options=deprecated_function_alias(18555, TensorProductOfCrystals.options)
-TensorProductOfCrystalsOptions=deprecated_function_alias(18555, TensorProductOfCrystals.options)
-

src/sage/combinat/k_tableau.py

@@ -4639,9 +4639,3 @@ def intermediate_shapes(t):
     for i in range(len(t.weight())+1):
         shapes += [ t.restrict(i).outer_shape()]
     return shapes
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-
-
-StrongTableaux.global_options = deprecated_function_alias(18555, StrongTableaux.options)

src/sage/combinat/permutation.py

@@ -8911,8 +8911,3 @@ def __setstate__(self, state):
 register_unpickle_override("sage.combinat.permutation", "CyclicPermutationsOfPartition_partition", CyclicPermutationsOfPartition)
 register_unpickle_override("sage.combinat.permutation", "CyclicPermutations_mset", CyclicPermutations)
 register_unpickle_override('sage.combinat.permutation_nk', 'PermutationsNK', PermutationsNK)
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-Permutations.global_options=deprecated_function_alias(18555, Permutations.options)
-PermutationOptions = deprecated_function_alias(18555, Permutations.options)

src/sage/combinat/ribbon_shaped_tableau.py

@@ -465,8 +465,3 @@ def __setstate__(self, state):
 from sage.misc.persist import register_unpickle_override
 register_unpickle_override('sage.combinat.ribbon', 'Ribbon_class', Ribbon_class)
 register_unpickle_override('sage.combinat.ribbon', 'StandardRibbons_shape', StandardRibbonShapedTableaux)
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-RibbonShapedTableaux.global_options = deprecated_function_alias(18555, RibbonShapedTableaux.options)
-StandardRibbonShapedTableaux.global_options = deprecated_function_alias(18555, StandardRibbonShapedTableaux.options)

src/sage/combinat/rigged_configurations/rc_crystal.py

@@ -453,8 +453,3 @@ def from_virtual(self, vrc):
         return self.element_class(self, partition_list=partitions, rigging_list=riggings)
 
     Element = RCHWNonSimplyLacedElement
-
-# deprecations from trac:18555
-from sage.misc.superseded import deprecated_function_alias
-CrystalOfRiggedConfigurations.global_options = deprecated_function_alias(18555, CrystalOfRiggedConfigurations.options)
-

src/sage/combinat/rigged_configurations/rigged_configurations.py

@@ -1912,8 +1912,3 @@ def from_virtual(self, vrc):
         return self.element_class(self, partitions)
 
     Element = KRRCTypeA2DualElement
-
-# deprecations from trac:18555
-from sage.misc.superseded import deprecated_function_alias
-RiggedConfigurations.global_options=deprecated_function_alias(18555, RiggedConfigurations.options)
-RiggedConfigurationOptions = deprecated_function_alias(18555, RiggedConfigurations.options)

src/sage/combinat/root_system/cartan_type.py

@@ -3086,9 +3086,3 @@ def __setstate__(self, dict):
         T = CartanType([dict['letter'], dict['n']])
         self.__class__ = T.__class__
         self.__dict__ = T.__dict__
-
-# deprecations from trac:18555
-from sage.misc.superseded import deprecated_function_alias
-CartanTypeFactory.global_options = deprecated_function_alias(18555, CartanTypeFactory.options)
-CartanTypeOptions = deprecated_function_alias(18555, CartanType.options)
-CartanType_abstract.global_options = deprecated_function_alias(18555, CartanType.options)

src/sage/combinat/skew_partition.py

@@ -1934,7 +1934,3 @@ def __iter__(self):
 
 from sage.misc.persist import register_unpickle_override
 register_unpickle_override('sage.combinat.skew_partition', 'SkewPartition_class', SkewPartition)
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-SkewPartitions.global_options=deprecated_function_alias(18555, SkewPartitions.options)

src/sage/combinat/skew_tableau.py

@@ -2543,7 +2543,3 @@ def __setstate__(self, state):
 # July 2013: But wait, there more!
 register_unpickle_override('sage.combinat.skew_tableau', 'StandardSkewTableaux_skewpartition',  StandardSkewTableaux_shape)
 register_unpickle_override('sage.combinat.skew_tableau', 'SkewTableau_class',  SkewTableau_class)
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-SkewTableaux.global_options=deprecated_function_alias(18555, SkewTableaux.options)

src/sage/combinat/tableau.py

@@ -9422,8 +9422,3 @@ def __contains__(self, x):
 register_unpickle_override('sage.combinat.tableau', 'SemistandardTableaux_p',  SemistandardTableaux_shape)
 register_unpickle_override('sage.combinat.tableau', 'SemistandardTableaux_nmu',  SemistandardTableaux_size_weight)
 register_unpickle_override('sage.combinat.tableau', 'SemistandardTableaux_pmu',  SemistandardTableaux_shape_weight)
-
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-Tableaux.global_options=deprecated_function_alias(18555, Tableaux.options)

src/sage/groups/all.py

@@ -16,9 +16,6 @@
              'merge_points', 'structure_description'],
             deprecation=(25785, "this is being removed from the global namespace"))
 
-# deprecation(24256)
-from sage.structure.element import generic_power as power
-
 lazy_import('sage.groups.class_function', 'ClassFunction')
 
 from .additive_abelian.all import *

src/sage/groups/generic.py

@@ -133,9 +133,6 @@
 multiplication_names = ( 'multiplication', 'times', 'product', '*')
 addition_names       = ( 'addition', 'plus', 'sum', '+')
 
-# deprecation(24256)
-from sage.structure.element import generic_power as power
-
 
 def multiple(a, n, operation='*', identity=None, inverse=None, op=None):
     r"""

src/sage/manifolds/manifold.py

@@ -2713,9 +2713,3 @@ def Manifold(dim, name, latex_name=None, field='real', structure='smooth',
 
 
 Manifold.options = TopologicalManifold.options
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-Manifold.global_options=deprecated_function_alias(18555, TopologicalManifold.options)
-ManifoldOptions = deprecated_function_alias(18555, TopologicalManifold.options)
-TopologicalManifold.global_options=deprecated_function_alias(18555, TopologicalManifold.options)

src/sage/structure/coerce.pyx

@@ -490,7 +490,7 @@ cdef class CoercionModel:
 
     - Robert Bradshaw
     """
-    def __init__(self, *args, **kwds):
+    def __init__(self):
         """
         EXAMPLES::
 
@@ -500,18 +500,10 @@ cdef class CoercionModel:
             sage: A = cm.get_action(ZZ, K, operator.mul)
             sage: f, g = cm.coercion_maps(QQ, int)
             sage: f, g = cm.coercion_maps(ZZ, int)
-
-        TESTS::
-
-            sage: cm = CoercionModel(4, .95)
-            doctest:...: DeprecationWarning: the 'lookup_dict_size' argument is deprecated
-            See http://trac.sagemath.org/24135 for details.
-            doctest:...: DeprecationWarning: the 'lookup_dict_threshold' argument is deprecated
-            See http://trac.sagemath.org/24135 for details.
         """
-        self.reset_cache(*args, **kwds)
+        self.reset_cache()
 
-    def reset_cache(self, lookup_dict_size=None, lookup_dict_threshold=None):
+    def reset_cache(self):
         """
         Clear the coercion cache.
 
@@ -529,12 +521,6 @@ cdef class CoercionModel:
             sage: cm.get_cache()
             ({}, {})
         """
-        if lookup_dict_size is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(24135, "the 'lookup_dict_size' argument is deprecated")
-        if lookup_dict_threshold is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(24135, "the 'lookup_dict_threshold' argument is deprecated")
         # This MUST be a mapping of tuples, where each
         # tuple contains at least two elements that are either
         # None or of type Map.

src/sage/structure/element.pyx

@@ -4283,55 +4283,3 @@ def coerce_binop(method):
             else:
                 return getattr(a, method.__name__)(b, *args, **kwargs)
     return new_method
-
-
-###############################################################################
-
-def generic_power(a, n, one=None):
-    """
-    Computes `a^n`, where `n` is an integer, and `a` is an object which
-    supports multiplication.  Optionally an additional argument,
-    which is used in the case that ``n == 0``:
-
-    - ``one`` - the "unit" element, returned directly (can be anything)
-
-    If this is not supplied, ``int(1)`` is returned.
-
-    EXAMPLES::
-
-        sage: from sage.structure.element import generic_power
-        sage: generic_power(int(12),int(0))
-        doctest:...: DeprecationWarning: import 'generic_power' from sage.arith.power instead
-        See http://trac.sagemath.org/24256 for details.
-        1
-        sage: generic_power(int(0),int(100))
-        0
-        sage: generic_power(Integer(10),Integer(0))
-        1
-        sage: generic_power(Integer(0),Integer(23))
-        0
-        sage: sum(generic_power(2,i) for i in range(17)) #test all 4-bit combinations
-        doctest:...: DeprecationWarning: import 'generic_power' from sage.arith.power instead
-        See http://trac.sagemath.org/24256 for details.
-        131071
-        sage: F = Zmod(5)
-        sage: a = generic_power(F(2), 5); a
-        2
-        sage: a.parent() is F
-        True
-        sage: a = generic_power(F(1), 2)
-        sage: a.parent() is F
-        True
-
-        sage: generic_power(int(5), 0)
-        1
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(24256, "import 'generic_power' from sage.arith.power instead")
-    if one is not None:
-        # Special cases not handled by sage.arith.power
-        if not n:
-            return one
-        if n < 0:
-            return ~arith_generic_power(a, -n)
-    return arith_generic_power(a, n)

src/sage/structure/global_options.py

@@ -1692,10 +1692,3 @@ def _reset(self, option=None):
             elif option in self._linked_value:
                 link, linked_opt=self._linked_value[option]
                 link._reset(linked_opt)
-
-
-# Deprecations from trac:18555. July 2016
-from sage.misc.superseded import deprecated_function_alias
-GlobalOptions.default_value=deprecated_function_alias(18555, GlobalOptions._default_value)
-GlobalOptions.dispatch=deprecated_function_alias(18555, GlobalOptions._dispatch)
-GlobalOptions.reset=deprecated_function_alias(18555, GlobalOptions._reset)

src/sage/structure/parent.pxd

@@ -23,8 +23,6 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
     cdef inline bint get_flag(self, int flag):
         return self.flags & flag
 
-    cpdef bint _is_coercion_cached(self, domain)
-    cpdef bint _is_conversion_cached(self, domain)
     cpdef register_coercion(self, mor)
     cpdef register_action(self, action)
     cpdef register_conversion(self, mor)

src/sage/structure/parent.pyx

@@ -1391,14 +1391,12 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
         self.init_coerce(False)
 
         if not unpickling:
-            if element_constructor is None:
-                try:
-                    element_constructor = self._element_constructor_
-                except AttributeError:
-                    raise RuntimeError("an _element_constructor_ method must be defined")
-            else:
-                from sage.misc.superseded import deprecation
-                deprecation(24363, "the 'element_constructor' keyword of _populate_coercion_lists_ is deprecated: override the _element_constructor_ method or define an Element attribute instead")
+            if element_constructor is not None:
+                raise ValueError("element_constructor can only be given when unpickling is True")
+            try:
+                element_constructor = self._element_constructor_
+            except AttributeError:
+                raise RuntimeError("an _element_constructor_ method must be defined")
         self._element_constructor = element_constructor
         self._element_init_pass_parent = guess_pass_parent(self, element_constructor)
 
@@ -1456,24 +1454,7 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
         self._embedding = None
         self._unset_coercions_used()
 
-    def is_coercion_cached(self, domain):
-        """
-        Deprecated method
-
-        TESTS::
-
-            sage: Parent().is_coercion_cached(QQ)
-            doctest:warning
-            ...
-            DeprecationWarning: is_coercion_cached is deprecated use _is_coercion_cached instead
-            See http://trac.sagemath.org/24254 for details.
-            False
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(24254, "is_coercion_cached is deprecated use _is_coercion_cached instead")
-        return self._is_coercion_cached(domain)
-
-    cpdef bint _is_coercion_cached(self, domain):
+    def _is_coercion_cached(self, domain):
         r"""
         Test whether the coercion from ``domain`` is already cached.
 
@@ -1488,24 +1469,7 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
         """
         return domain in self._coerce_from_hash
 
-    def is_conversion_cached(self, domain):
-        """
-        Deprecated method
-
-        TESTS::
-
-            sage: Parent().is_conversion_cached(QQ)
-            doctest:warning
-            ...
-            DeprecationWarning: is_conversion_cached is deprecated use _is_conversion_cached instead
-            See http://trac.sagemath.org/24254 for details.
-            False
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(24254, "is_conversion_cached is deprecated use _is_conversion_cached instead")
-        return self._is_conversion_cached(domain)
-
-    cpdef bint _is_conversion_cached(self, domain):
+    def _is_conversion_cached(self, domain):
         r"""
         Test whether the conversion from ``domain`` is already set.
 

src/sage/structure/parent_old.pyx

@@ -69,31 +69,10 @@ cdef class Parent(parent.Parent):
     def __cinit__(self):
         self._has_coerce_map_from = MonoDict()
 
-    def __init__(self, coerce_from=None, actions=None, embeddings=None, *, category=None):
+    def __init__(self, *, category=None):
         self.init_coerce(False)
-        if coerce_from is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(24614, "the 'coerce_from' keyword is deprecated")
-            self._coerce_from_list = list(coerce_from)
         self._coerce_from_hash = MonoDict()
-        if actions is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(24614, "the 'actions' keyword is deprecated")
-            self._action_list = list(actions)
-
-        cdef parent.Parent other
-        if embeddings is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(24614, "the 'embeddings' keyword is deprecated")
-            for mor in embeddings:
-                other = mor.domain()
-                print("embedding", self, " --> ", other)
-                print(mor)
-                other.init_coerce() # TODO remove when we can
-                other._coerce_from_list.append(mor)
-
         self._set_element_constructor()
-
         if category is not None:
             self._init_category_(category)