Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate args of Parent_old.__init__ #24614

Closed
jdemeyer opened this issue Jan 30, 2018 · 5 comments
Closed

Deprecate args of Parent_old.__init__ #24614

jdemeyer opened this issue Jan 30, 2018 · 5 comments
Labels
c: coercion p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@jdemeyer
Copy link
Contributor

This is the signature of Parent_old.__init__:

    def __init__(self, coerce_from=[], actions=[], embeddings=[], category=None):

All arguments except for category should be deprecated.

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 35137da

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/24614
@jdemeyer jdemeyer added this to the sage-8.2 milestone Jan 30, 2018
@jdemeyer
Copy link
Contributor Author

Branch: u/jdemeyer/deprecate_args_of_parent_old___init__

@jdemeyer
Copy link
Contributor Author

New commits:

35137daDeprecate args of Parent_old.__init__

@jdemeyer
Copy link
Contributor Author

Commit: 35137da

@videlec
Copy link
Contributor

videlec commented Jan 30, 2018

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Feb 2, 2018

Changed branch from u/jdemeyer/deprecate_args_of_parent_old___init__ to 35137da

@vbraun vbraun closed this as completed in bb2b730 Feb 2, 2018
@jdemeyer jdemeyer mentioned this issue Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec