Deprecate sage.structure.element.generic_power

[jdemeyer]

In #24247, the implementation of generic_power was moved to a new module sage.arith.power. The old implementation should be deprecated. This is done in a separate ticket instead of #24247 because that ticket already does a lot.

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: f855f20

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24256

[jdemeyer]

Changed dependencies from #24247 to #5574

[jdemeyer]

Branch: u/jdemeyer/ticket/24256

[sagetrac-git]

Commit: 6f5a998

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6f5a998

Deprecate sage.structure.element.generic_power

[sagetrac-git]

Changed commit from 6f5a998 to 64837df

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

64837df

Deprecate sage.structure.element.generic_power

[jdemeyer]

Changed dependencies from #5574 to none

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:7

I believe you are still missing one in schemes/morphism.py:

from sage.structure.element import (AdditiveGroupElement, RingElement,
        Element, generic_power, parent, coercion_model)

From the old patchbot reports, there are also some deprecation warnings popping up for NTL. The only plausible reason I can see from grepping is it is fixed by #5574.

Also, I don't understand why you did not make the change in groups/generic.py?

[jdemeyer]

comment:8

Replying to @tscrim:

Also, I don't understand why you did not make the change in groups/generic.py?

What is "the change"? I kept the import because some code might be importing power from that module. But it's the same generic_power function, so it's still deprecated (as indicated by the comment).

[tscrim]

comment:9

Replying to @jdemeyer:

Replying to @tscrim:

Also, I don't understand why you did not make the change in groups/generic.py?

What is "the change"?

-from sage.structure.element import generic_power
+from sage.arith.power import generic_power

I kept the import because some code might be importing power from that module. But it's the same generic_power function, so it's still deprecated (as indicated by the comment).

I see, you are de facto deprecating the import from there as well.

[jdemeyer]

comment:10

Replying to @tscrim:

I see, you are de facto deprecating the import from there as well.

Yes, exactly.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f855f20

Further fixes to generic_power use

[sagetrac-git]

Changed commit from 64837df to f855f20

[jdemeyer]

comment:12

Green bot now.

[tscrim]

comment:13

Thanks.

[vbraun]

Changed branch from u/jdemeyer/ticket/24256 to f855f20