New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bundled gems from rbs/stdlib #782

Open

ksss wants to merge 9 commits into ruby:main from ksss:bundled-gems

Collaborator

ksss commented Feb 2, 2025 •

edited

Loading

From ruby/rbs#2258

Naming

bigdecimal and bigdecimal-math were merged due to name restrictions.

Commit log

I wanted to fully copy the commit log, but it was difficult, so I opted to leave only a simple credit instead.

Testing

As for the tests, their format was different, and rewriting all of them would have been too much work, so I decided to abandon that approach.

Behavior after merge

Before adding to ALUMNI_STDLIBS in rbs
- stdlib's will be used.
After adding to ALUMNI_STDLIBS in rbs
- stdlib's will be used. And a warning log will be output.
After removing from the rbs repository
- If listed in rbs_collection.yaml
  - If listed in manifest.yaml
    - If listed in ALUMNI_STDLIBS
      - Nothing is logged and gem_rbs_collection's will be used.
    - If not listed in ALUMNI_STDLIBS
      - Nothing is logged and gem_rbs_collection's will be used.
  - If not listed in manifest.yaml
    - If listed in ALUMNI_STDLIBS
      - Nothing is logged and gem_rbs_collection's will be used.
    - If not listed in ALUMNI_STDLIBS
      - Nothing is logged and gem_rbs_collection's will be used.
- If not listed in rbs_collection.yaml
  - If listed in manifest.yaml
    - If listed in ALUMNI_STDLIBS
      - A deprecated log will be output and gem_rbs_collection's will be used.
    - If not listed in ALUMNI_STDLIBS
      - Nothing is logged and nothing is used. 🤔
  - If not listed in manifest.yaml
    - If listed in ALUMNI_STDLIBS
      - Nothing is logged and nothing is used.
    - If not listed in ALUMNI_STDLIBS
      - Nothing is logged and nothing is used.

ksss added 9 commits

February 2, 2025 14:45


          Move minitest from rbs/stdlib

ce6971e

See also:
- ruby/rbs#2258
- ruby/rbs#1009
- ruby/rbs#1694
- ruby/rbs#2093

Thank you:
- @ksss
- @stevegeek


          Move net-smtp from rbs/stdlib

a09c662

See also:
- ruby/rbs#2258
- ruby/rbs#1560

Thank you:
- @tk0miya


          Move base64 from rbs/stdlib

0fc4e8c

See also:
- ruby/rbs#2258


          Move bigdecimal from rbs/stdlib

See also:
- ruby/rbs#2258
- ruby/rbs#817
- ruby/rbs#936
- ruby/rbs#1053

Thank you:
- @ybiquitous
- @takahashim
- @piotaixr


          Move bigdecimal-math from rbs/stdlib

fde297c

Since gem_rbs_collection is managed by gem names,
we cannot create a separate directory named bigdecimal-math.
For now, I will merge it into bigdecimal.

See also:
- ruby/rbs#2258

Thank you:
- @mihyaeru21


          Move abbrev from rbs/stdlib

c455ec4

See also:
- ruby/rbs#2258


          Move nkf from rbs/stdlib

f4e03df

See also:
- ruby/rbs#2258
- ruby/rbs#873

Thank you:
- @fabon-f


          Move csv from rbs/stdlib

04090a6

See also:
- ruby/rbs#2258
- ruby/rbs#2099
- ruby/rbs#2012
- ruby/rbs#2003
- ruby/rbs#1903
- ruby/rbs#1864
- ruby/rbs#1738
- ruby/rbs#241

Thank you:
- @euglena1215
- @aki19035vc
- @tk0miya
- @m11o
- @connorshea


          Move observer from rbs/stdlib

bcd09b5

See also:
- ruby/rbs#2258

Contributor

tk0miya commented Feb 2, 2025

Thank you for your great work. Are reviewers needed for these modules?
I've read NKF and CSV to update types. So I can help maintain them a little.

Collaborator Author

ksss commented Feb 2, 2025

@tk0miya
Of course you are welcome to join.
I believe that bundled gems should have more than one reviewer.
Bundled gems, like other gems, are intended to be maintained by the community.
For now, we will move them to gem_rbs_collection, but for some gems, we are also planning to migrate them to the gem repository.

ksss marked this pull request as ready for review

February 2, 2025 14:38

github-actions bot commented Feb 2, 2025

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

/merge: Merge this PR if CI passes

`abbrev`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`base64`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`bigdecimal`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`csv`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`minitest`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`net-smtp`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`nkf`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

`observer`

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.

ksss requested a review from pocke

February 10, 2025 07:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet