Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nkf] Add RBS for "nkf" #873

Merged
merged 1 commit into from
Jan 31, 2022
Merged

[nkf] Add RBS for "nkf" #873

merged 1 commit into from
Jan 31, 2022

Conversation

fabon-f
Copy link
Contributor

@fabon-f fabon-f commented Jan 22, 2022

No description provided.

@pocke
Copy link
Member

pocke commented Jan 24, 2022

Thanks for the PR. It looks good to me but a test failed due to #869. Could you rebase the branch onto the master branch?

@fabon-f
Copy link
Contributor Author

fabon-f commented Jan 28, 2022

Rebased. (If I didn't do something wrong)

soutaro
soutaro approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro merged commit 1582524 into ruby:master Jan 31, 2022
@fabon-f fabon-f deleted the add_nkf branch February 1, 2022 17:39
ksss added a commit to ksss/gem_rbs_collection that referenced this pull request Feb 2, 2025
@ksss
Move nkf from rbs/stdlib
f4e03df 
See also:
- ruby/rbs#2258
- ruby/rbs#873

Thank you:
- @fabon-f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabon-f @pocke @soutaro