Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minitest to stdlib #1009

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Add Minitest to stdlib #1009

merged 6 commits into from
Jun 22, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented May 28, 2022

ksss added a commit to ksss/orthoses-rails that referenced this pull request May 30, 2022
@soutaro
Copy link
Member

soutaro commented Jun 20, 2022

@ksss Thank you so much for your another great contribution!
Could you revert the change of Rakefile since your another PR #1010 allows to remove that fix?

This reverts commit 24411e2.
since ruby#1010
@ksss
Copy link
Collaborator Author

ksss commented Jun 21, 2022

OK, Reverted.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@soutaro soutaro merged commit 427eaee into ruby:master Jun 22, 2022
@ksss ksss deleted the minitest branch June 22, 2022 03:06
ksss added a commit to ksss/gem_rbs_collection that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants