Followup from #9 and enable linters. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
force-pushed
the
logging-followup
branch
from
0509c7d to
142a02e
Compare
|
|
@ros-pull-request-builder retest this please |
clalancette
force-pushed
the
logging-followup
branch
from
142a02e to
166e638
Compare
While we are in here, fix up a few typos and cleanup the code to conform to the linting rules. Signed-off-by: Steven! Ragnarök <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
logging-followup
branch
from
166e638 to
9f17e27
Compare
|
CI:
|
clalancette
approved these changes
Oct 4, 2019
sloretz
reviewed
Oct 4, 2019
nuclearsandwich
commented
Oct 4, 2019
There was a problem hiding this comment.
Thanks for picking up the torch @clalancette. Aside from @sloretz's question about the removed log severity enum nothing else jumps out as an issue. ✔️
sloretz
reviewed
Oct 4, 2019
sloretz
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup from #9 and the start of a resolution for #11 (enables linters but does not address any of the reported issues).
ament_copyright fails on the included FindLog4cxx.cmake file. I don't see FindLog4cxx.cmake in the current HEAD of the CMake upstream repository nor have I seen a way to disable copyright checks for just one file while keeping them for the rest of the package.
Fixes #11