Rename result variable for clarity. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
force-pushed
the
logging-followup
branch
from
5383fde to
be31210
Compare
wjwwood
approved these changes
May 6, 2019
clalancette
approved these changes
May 6, 2019
|
CI for this change was run in ros2/rcl_logging#12 (comment) Though there are failures in the run, they're all due to the fact that linters are now being run for the rcl_logging packages so this small internal change broke nothing (as one would hope). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #155. As mentioned by @clalancette
basename_copyis also a candidate as it is whatbasecis intended to abbreviate.