Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing the input eigen matrix to be csc when copying it into an osqp matrix #57

Merged
merged 4 commits into from
May 14, 2020
Merged

Forcing the input eigen matrix to be csc when copying it into an osqp matrix #57

merged 4 commits into from
May 14, 2020

Conversation

S-Dafarra
Copy link
Collaborator

No description provided.

@S-Dafarra S-Dafarra requested a review from GiulioRomualdi May 13, 2020 16:09
@S-Dafarra S-Dafarra self-assigned this May 13, 2020
@S-Dafarra S-Dafarra mentioned this pull request May 13, 2020
Closed
@GiulioRomualdi
Copy link
Member

Thanks @S-Dafarra for working on this. This should fix the problem spotted in #54, right?

@S-Dafarra
Copy link
Collaborator Author

Thanks @S-Dafarra for working on this. This should fix the problem spotted in #54, right?

That was the idea, even if I did not add a proper test for it. Any idea?

@S-Dafarra
Copy link
Collaborator Author

That was the idea, even if I did not add a proper test for it. Any idea?

In ad6d2a3 I added a simple test that is failing with the devel version but not with the patch.

@GiulioRomualdi
Copy link
Member

That was the idea, even if I did not add a proper test for it. Any idea?

In ad6d2a3 I added a simple test that is failing with the devel version but not with the patch.

Perfect. You can bump the version from 0.6.101 to 0.6.102 and then merge!

@S-Dafarra
Copy link
Collaborator Author

I just bumped to 0.6.102 in #52 😁 If you agree, we can land #52 first and then I bump the version of this one 😁

@GiulioRomualdi
Copy link
Member

Deal!

@S-Dafarra
Copy link
Collaborator Author

Bumped to 0.6.103. Ready to merge.

@GiulioRomualdi GiulioRomualdi merged commit d27c484 into robotology:devel May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi GiulioRomualdi approved these changes

Assignees

@S-Dafarra S-Dafarra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-Dafarra @GiulioRomualdi