-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that all the settings are actually available. #52
Check that all the settings are actually available. #52
Conversation
1ea514d
to
148b4d7
Compare
Rebased and bumped patch version. Removed from draft. |
Should we use a static_assert if the variable is not defined? |
I totally missed this 😁. The point of adding the error instead of the assert is that code would work anyway even if you are trying to use that quantity. With the |
Right |
If we would use |
Add time limit setting.
148b4d7
to
6e1e14e
Compare
Merging! |
As it can be noticed from the
osqp
code some settings may not be available depending on the specific Cmake settings. With this PR we copy the same checks adding an error message in case some settings are not available.I also added the
time_limit
setting (see #38).In draft since I have to bump the version number, but there are other PR open at the moment.