Use import_methods instead of include in refinements if available. #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
reviewed
Oct 28, 2021
lib/graphql/deprecated_dsl.rb
Outdated
| TYPE_CLASSES.each do |type_class| | ||
| refine type_class.singleton_class do | ||
| include Methods | ||
| if Refinement.private_method_defined?(:import_methods) |
There was a problem hiding this comment.
Suggested change
| if Refinement.private_method_defined?(:import_methods) | |
| if defined?(::Refinement) && Refinement.private_method_defined?(:import_methods) |
It looks like Refinement was added in the patch you linked earlier: ruby/ruby@6606597#diff-ddea6b44375166521cc45b79d4c54b08594c13872acc5ec279f07d2eda8c32baR684 Judging by CI failures, I guess we should check if it exists first?
Ruby 3.1 deprecate the use of include/prepend inside refienements Ref: https://bugs.ruby-lang.org/issues/17429
casperisfine
force-pushed
the
ruby-3.1-refinement-include
branch
from
8625f01 to
ddce9dc
Compare
|
Thanks for the fix! |
dipth
added a commit
to dipth/graphql-batch
that referenced
this pull request
Feb 14, 2023
to add support for Ruby 3.2 related to the use of include in refinements as fixed in this PR: rmosolgo/graphql-ruby#3674
a-lavis
added a commit
to kickstarter/graphql-ruby
that referenced
this pull request
Aug 25, 2023
a-lavis
added a commit
to kickstarter/graphql-ruby
that referenced
this pull request
Jan 22, 2024
a-lavis
added a commit
to kickstarter/graphql-ruby
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.1 deprecate the use of include/prepend inside refinements
Ref: https://bugs.ruby-lang.org/issues/17429