Add support for Ruby 3.2 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to add support for Ruby 3.2 related to the use of include in refinements as fixed in this PR: rmosolgo/graphql-ruby#3674
Closed
|
Excellent, thanks @dipth |
|
@swalkinshaw no problem. Any chance you could push an update to rubygems? |
|
I can, but why is that actually needed on your end? This would only affect people on graphql < 1.12 since the other change is in CI only. |
|
You're right. We're doing a number of dependency upgrades ahead of upgrading to Ruby 3.2, so I must have mixed this one together with another one that did have actual code changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes adds support for Ruby 3.2 by bumping the minimum required version of
graphqlfrom1.10.0to1.12.18which fixes a Ruby 3.2 incompatibility related to the use of include in refinements as fixed in this PR:rmosolgo/graphql-ruby#3674