Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.2 to CI #155

Closed
wants to merge 1 commit into from
Closed

Add Ruby 3.2 to CI #155

wants to merge 1 commit into from

Conversation

dipth
Copy link
Contributor

@dipth dipth commented Feb 14, 2023

No description provided.

@dipth dipth closed this Feb 14, 2023
@dipth dipth reopened this Feb 14, 2023
@dipth
Copy link
Contributor Author

dipth commented Feb 14, 2023

It appears that I need to rerun the CLA workflow, but it doesn't appear that I have any way to do so...

@swalkinshaw
Copy link
Contributor

@dipth done. Looks like there's a legit failure on 3.2 due to the usage of refinements.

@dipth
Copy link
Contributor Author

dipth commented Feb 14, 2023

@swalkinshaw do you have any plans to address Ruby 3.2 compatibility?

@swalkinshaw
Copy link
Contributor

Actually the failure is due an older version of graphql ruby being tested. It was fixed in: rmosolgo/graphql-ruby#3674

So we have two choices:

  1. bump required graphql version
  2. don't test the graphql 1.10 gemfile on 3.2

@dipth
Copy link
Contributor Author

dipth commented Feb 14, 2023

I would personally lean towards bumping the graphql dependency, but it's your call 🙂

@swalkinshaw
Copy link
Contributor

Yeah I'm good with that. Would be interested in doing that?

@dipth
Copy link
Contributor Author

dipth commented Feb 14, 2023

I can give it a try 🙂

@dipth
Copy link
Contributor Author

dipth commented Feb 14, 2023

Closed in favor of:
#156

@dipth dipth closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants