Auth smoke tests #4673

dac09 · 2022-03-06T07:11:58Z

Add Auth smoke tests

This PR does the following:

Modifies the test-project generator (and updates fixture) to add a new profile page that:
a) Is wrappedin <Private>
b) Uses useAuth and prints some of the values
c) Adds signup and login tests
d) Adds playwright tests to check auth props are rendered correctly
e) Adds tests to check for redirects
f) Adds RBAC checks to see
i) If hasRole("ADMIN") returns true
ii) deleteContact with @requireAuth(roles: ["ADMIN"]) directive works as expected
g) Adds unit test for ProfilePage, which lets us double check mockCurrentUser is working in unit tests

Todo:

Tsc failure expected in workflow - this will be resolved in fix(auth): hasRole handles when currentUser.roles is a string #4678
Re-enable isAdmin check in rbac spec - (also waiting for fix(auth): hasRole handles when currentUser.roles is a string #4678)
Regenerate fixture once all up-to-date

Closes #4486

Update fixture

…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: Clean console.log in dev tools (redwoodjs#4671)

…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: Update dependency graphql-helix to v1.12.0 (redwoodjs#4692) Update dependency @supabase/supabase-js to v1.31.1 (redwoodjs#4690) Update dependency css-loader to v6.7.1 (redwoodjs#4691) update yarn.lock v0.49.0 Update dependency @azure/msal-browser to v2.22.1 (redwoodjs#4686) Update dependency magic-sdk to v8.1.0 (redwoodjs#4684) run smoke-test on Node 14 and 16 Update typescript-eslint monorepo to v5.14.0 (redwoodjs#4687) Update dependency fastify to v3.27.3 (redwoodjs#4683) Update dependency @supabase/supabase-js to v1.31.0 (redwoodjs#4677) Update dependency @auth0/auth0-spa-js to v1.20.1 (redwoodjs#4682) Codemod for webhook verifier option renaming (redwoodjs#4675)

dac09 · 2022-03-08T17:52:51Z

It's alive! It's alive!

https://s.tape.sh/w6waC16z

…in profilePage

dac09 · 2022-03-10T14:56:39Z

@thedavidprice do you want to start reviewing? Awaiting merging the other PR (just holding till Rob does a once over) - then will regenerate the fixture.

dac09 · 2022-03-10T14:59:49Z

__fixtures__/test-project/web/src/pages/ProfilePage/ProfilePage.test.tsx

+
+describe('ProfilePage', () => {
+  it('renders successfully', async () => {
+    mockCurrentUser({


This lets us verify that mockCurrentUser is working

dac09 · 2022-03-10T15:00:07Z

__fixtures__/test-project/web/src/pages/ProfilePage/ProfilePage.tsx

+          </tr>
+        </thead>
+        <tbody>
+          {Object.keys(currentUser).map((key) => {


Just prints the keys from currentUser in useAuth.

dac09 · 2022-03-10T15:00:38Z

tasks/smoke-test/playwright-fixtures/devServer.fixture.ts

      // "port" fixture uses a unique value of the worker process index.
-      await use(9000 + workerInfo.workerIndex)
+      await use(9000)


Changes here are because we actually don't want to spin up multiple dev servers (because our dev process regenerates some files)

This does not affect running tests in parallel though, because browser contexts are isolated

dac09 · 2022-03-10T15:01:44Z

tasks/smoke-test/tests/rbacChecks.spec.ts

+  fs.writeFileSync(
+    path.join(process.env.PROJECT_PATH, 'scripts/makeAdmin.ts'),
+    `
+  import { db } from 'api/src/lib/db'


We use rw exec to convert the user to an admin

dac09 · 2022-03-10T15:01:57Z

tasks/smoke-test/tests/rbacChecks.spec.ts

+    '<td>EMAIL</td><td>[email protected]</td>'
+  )
+
+  // const isAdminRow = await page.waitForSelector('*css=tr >> text=Is Admin')


Will enable once the other PR is merged

SuperHelpfulReminder™

do the thing you were waiting to do here

dac09 · 2022-03-10T15:02:47Z

tasks/test-project/codemods/routes.js

+  return root
+    .findJSXElements('Route')
+    .filter(
+      j.filters.JSXElement.hasAttributes({


Finds the <Route path="/profile"/> and wraps in a <Private> component

thedavidprice · 2022-03-10T15:48:44Z

@dac09 Amazing work! I just checked out the Tape.

Understood about dependency on #4678

Will review today ✅

dac09 · 2022-03-14T07:49:45Z

@thedavidprice ready to merge! ✅✅✅✅✅✅✅

…d into feat/auth-checks-smoke-test * 'feat/auth-checks-smoke-test' of github.com:dac09/redwood: fix(deps): update dependency esbuild to v0.14.27 (redwoodjs#4755) chore(deps): update dependency cypress to v9.5.2 (redwoodjs#4754) chore(deps): update dependency @types/lodash to v4.14.180 (redwoodjs#4751) fix(deps): update typescript-eslint monorepo to v5.15.0 (redwoodjs#4752) fix(deps): update dependency esbuild to v0.14.26 (redwoodjs#4747) Setup futureExpiresDate in constructor (redwoodjs#4742) chore(deps): update dependency @clerk/clerk-sdk-node to v2.9.10 (redwoodjs#4746) fix(deps): update dependency eslint-plugin-react to v7.29.4 (redwoodjs#4745)

Use contacts count to have more reliable tests

…edited or not

…d into feat/auth-checks-smoke-test * 'feat/auth-checks-smoke-test' of github.com:dac09/redwood: chore(deps): update dependency @playwright/test to v1.20.0 (redwoodjs#4757)

…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: ignore @types/lru-cache (redwoodjs#4759) chore(deps): update dependency zx to v5.3.0 (redwoodjs#4758)

dac09 · 2022-03-15T09:59:13Z

I've updated it again. I had some git issues apparently (or just a problem between the keyboard and the chair) - didn't have the latest RBAC tests.

I've also updated the auth checks, because I realised that we were getting false positives with the error selectors... painfulllll 😭

thedavidprice · 2022-03-15T20:25:45Z

@dac09 Contacts work looks 🤯

Just incase you're reviewing another PR later, I think we should enforce that we don't modify src files in fixtures or in the test from now on! It makes it harder, but it'll save us soooo much effort in the future!

Just so I'm clear, you mean:

we do not allow manual, direct changes to any of the __fixtures__/ projects, correct?
instead, if we need to update, we should add the modification to the build:test-project tasks, correct?

Local Test-project dbAuth still not working

I still can't get local dbAuth to work (see previous comment above). I hope it's just because I'm missing something obvious.

If I'm reading the auth tests correctly, you're able to create a user and login (note: the login and home redirect should happen at the same time new user successfully created). But I can do that successfully when I try locally.

Steps to reproduce:

check out this PR branch
yarn build:test-project --ts --link <directory>
cd and yarn rw dev
try to create a new user and log in

Working
I can confirm a user is being created in the DB. API Get is good. Networking shows function calls.

Not working
I cannot log in. Redirect and login flow is not working.

I'm at a loss... something obvious I'm missing?

Safari-15Mar22_12-54-22.mp4

Testing Main Branch

I now believe dbAuth is broken in main. Will confirm, open an issue if necessary, then link to this.

thedavidprice · 2022-03-15T20:41:14Z

Confirmed this is a bug in main. See #4767

@dac09 Again, I don't know why the auth smoke test is passing if I understand correctly that it's stepping through creating a user and logging in. If the test was failing and/or we confirm the behavior is 1-to-1, it will be helpful to merge this PR in order to resolve #4767 And/or the fix can be applied here.

I could be doing something wrong, but right now I can't figure out what that might be.

thedavidprice

Need to resolve dbAuth login bug #4767

TBD if we resolve here and then merge or merge and use this to resolve

thedavidprice · 2022-03-15T21:41:27Z

Issue was specific to Safari. We were missing #4722

I'm will update and rebuild fixture. Then we're gtg 🚀

Add profile page generation

fc59cb7

jtoar assigned dac09 Mar 6, 2022

dac09 added the release:chore This PR is a chore (means nothing for users) label Mar 6, 2022

dac09 added 7 commits March 7, 2022 13:55

Fix profile page codemods

fd0acee

Update fixture

Merge branch 'main' of github.com:redwoodjs/redwood into feat/auth-ch…

9ed479d

…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: Clean console.log in dev tools (redwoodjs#4671)

Add codemod for profilePageTest so we check mockCurrentUser too

71c8b98

Fix: stop interval when server is up

ee16ee4

Use the same port for all workers

4779f1d

Add initial auth checks specc

efd4d35

Add authChecks with signup

b37dd81

dac09 mentioned this pull request Mar 8, 2022

[for discussion] Adding Auth functional tests to Playwright Smoke-test #4565

Closed

dac09 added 3 commits March 9, 2022 00:07

Update test-project fixture

428e567

Small tweaks to smoke test because we edit the title

dcc4c6b

dac09 added 5 commits March 10, 2022 13:20

Update authProvider to support string as role | Handle loading state …

883180d

…in profilePage

Undo auth provider type change for now, handle it in separate PR

90f35c3

Add rbac checks

ace4b34

Update fixture

3ef5127

Re-enable admin checks (will cause failure)

c517852

dac09 mentioned this pull request Mar 10, 2022

Allow requireAuth directive to be used with a string or array of strings #4680

Merged

dac09 requested a review from thedavidprice March 10, 2022 14:55

dac09 commented Mar 10, 2022

View reviewed changes

dac09 added 13 commits March 15, 2022 11:14

Regenerate fixture just to be sure

c7e155c

Merge branch 'main' into feat/auth-checks-smoke-test

90b637c

Ooops, forgot to commit RBAC checks

fd819cb

Use beforeAll instead of beforeEach in rbac

4dd0eb0

Parallelize rbac signups

8bc2a61

Use contacts count to have more reliable tests

Merge branch 'main' into feat/auth-checks-smoke-test

b69909b

Update auth checks so that it actually verifies if the post has been …

07bb80e

…edited or not

Merge branch 'feat/auth-checks-smoke-test' of github.com:dac09/redwoo…

e525796

…d into feat/auth-checks-smoke-test * 'feat/auth-checks-smoke-test' of github.com:dac09/redwood: chore(deps): update dependency @playwright/test to v1.20.0 (redwoodjs#4757)

dunno what happened with the auth selectors

22392c6

Use first selector for article

59ceda7

Merge branch 'main' of github.com:redwoodjs/redwood into feat/auth-ch…

123c6b2

…ecks-smoke-test * 'main' of github.com:redwoodjs/redwood: ignore @types/lru-cache (redwoodjs#4759) chore(deps): update dependency zx to v5.3.0 (redwoodjs#4758)

Make it resilient on faster machines i.e. macs

f561e06

Merge branch 'main' into feat/auth-checks-smoke-test

e2dff3e

thedavidprice mentioned this pull request Mar 15, 2022

[priority bug in main] dbAuth login is not working in main #4767

Closed

thedavidprice requested changes Mar 15, 2022

View reviewed changes

thedavidprice added 2 commits March 15, 2022 14:41

Merge branch 'main' into feat/auth-checks-smoke-test

e4dde2d

update fixture api/src/functions/auth.ts

5c077f7

thedavidprice approved these changes Mar 15, 2022

View reviewed changes

thedavidprice merged commit 3982d32 into redwoodjs:main Mar 15, 2022

jtoar added this to the next-release milestone Mar 15, 2022

This was referenced Mar 15, 2022

Add yarn 3 to create redwood app template #4761

Merged

Use GraphQL Yoga #4712

Merged

thedavidprice modified the milestones: next-release, v0.50.0 Mar 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auth smoke tests #4673

Auth smoke tests #4673

dac09 commented Mar 6, 2022 •

edited

Loading

dac09 commented Mar 8, 2022

dac09 commented Mar 10, 2022

dac09 Mar 10, 2022

dac09 Mar 10, 2022

dac09 Mar 10, 2022 •

edited

Loading

dac09 Mar 10, 2022

dac09 Mar 10, 2022

thedavidprice Mar 10, 2022

dac09 Mar 10, 2022

thedavidprice commented Mar 10, 2022

dac09 commented Mar 14, 2022

dac09 commented Mar 15, 2022

thedavidprice commented Mar 15, 2022

thedavidprice commented Mar 15, 2022 •

edited

Loading

thedavidprice left a comment

thedavidprice commented Mar 15, 2022

Auth smoke tests #4673

Auth smoke tests #4673

Conversation

dac09 commented Mar 6, 2022 • edited Loading

Add Auth smoke tests

dac09 commented Mar 8, 2022

dac09 commented Mar 10, 2022

dac09 Mar 10, 2022

Choose a reason for hiding this comment

dac09 Mar 10, 2022

Choose a reason for hiding this comment

dac09 Mar 10, 2022 • edited Loading

Choose a reason for hiding this comment

dac09 Mar 10, 2022

Choose a reason for hiding this comment

dac09 Mar 10, 2022

Choose a reason for hiding this comment

thedavidprice Mar 10, 2022

Choose a reason for hiding this comment

dac09 Mar 10, 2022

Choose a reason for hiding this comment

thedavidprice commented Mar 10, 2022

dac09 commented Mar 14, 2022

dac09 commented Mar 15, 2022

thedavidprice commented Mar 15, 2022

Local Test-project dbAuth still not working

Testing Main Branch

thedavidprice commented Mar 15, 2022 • edited Loading

thedavidprice left a comment

Choose a reason for hiding this comment

thedavidprice commented Mar 15, 2022

dac09 commented Mar 6, 2022 •

edited

Loading

dac09 Mar 10, 2022 •

edited

Loading

thedavidprice commented Mar 15, 2022 •

edited

Loading