Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[for discussion] Adding Auth functional tests to Playwright Smoke-test #4565

Closed
wants to merge 1 commit into from

Conversation

thedavidprice
Copy link
Contributor

For discussion re: #4486

@dac09 I started playing around with how to use Playwright + Test-project with dbAuth to do some basic Auth functional testing.

This is for discussion only. Let's close once path is determined.

Playwright looks like it will make this super simple:

  • should it be a separate test or add-on tests to either or both rw dev and rw serve; long-term I prefer standalone but game to do what needs to be done right now
  • I think this will better serve us as a stand-alone GH workflow; if easy, let's do that now. But I want something up asap so if using Smoke-test workflow for now, I'm all for it
  • I suggest we use the Test-project until proven otherwise. I can see why, in the future, we'll want a separate fixture. But for the tests we need now this feels like the foundation we need

Reactions and suggestions?

@dac09
Copy link
Contributor

dac09 commented Feb 24, 2022

It makes sense to use the smoke-test since you added the dbauth stuff in already!

I do want to expand on this a bit more though, because the issues we see are often more nuanced e.g. refresh the page, private routes, etc.

@thedavidprice
Copy link
Contributor Author

I do want to expand on this a bit more though, because the issues we see are often more nuanced e.g. refresh the page, private routes, etc.

@dac09 please do! And feel free to close this PR if/as needed. I want to hand this over as I can't dedicate the time even though it's priority.

@dac09
Copy link
Contributor

dac09 commented Mar 8, 2022

Closing this as its rolled into auth checks in #4673

@dac09 dac09 closed this Mar 8, 2022
@thedavidprice thedavidprice deleted the dsp-wip-auth-functional-test branch March 8, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

2 participants