-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn 3 to create redwood app template #4761
Conversation
@jtoar I'd suggest we move completely to Yarn 3 and do not specifically test for compatibility. We should strongly encourage everyone to migrate their projects to Yarn 3. In this PR, that means:
Did I miss anything? |
updated from main including Auth Smoke Tests via #4673 |
@jtoar I started working on changes to build:test-project to update the fixture to use Yarn 3. See 72992df
Rebuilding the Test-project fixtureI think tried (unsuccessfully) to rebuild the
The initial
Perhaps it's now an error running a yarn 3 command inside a Yarn 3 process? |
The smoke test's failing on |
.github/workflows/smoke-test.yaml
Outdated
run: | | ||
yarn rw prisma generate | ||
yarn rw prisma migrate reset --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtoar let's see if this one passes, but because I use this for Telemetry as well, let's not replace any of the specific commands. In this case, just add this to the dm up step, eg:
run: |
yarn rw prisma migrate reset --force
yarn rw dataMigrate up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't work; trying dm up
before install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtoar the code and updates look good. However, I still can't get the build:test-project commands to work.
I just tried yarn build:test-project --rebuildFixture
and ran into the same error I reported previously with Tailwind and/or any following yarn command.
If I cd into the temporary directory, I can't get any yarn commands to work, including yarn install. Always the same error about
➤ YN0001: │ Error: ENOENT: no such file or directory, lstat '/private/var/folders/wl/drx1fhwd2pjdmlyypfdt9kqc0000gn/T/redwood-test-project/2022-03-16T18-44-41.739Z/node_modules/@redwoodjs/core/node_modules/@babel/cli/node_modules/semver'
Did you ever get the commands to work locally?
Update here via @jtoar:
So this is not specific to the work here. Instead it's something broken with project:copy (but strangely not project:sync) I'm going to run a local sanity check and then hopefully proceed with this PR as is. Dom will work on project:copy fix in follow-up. |
✅ Deploy Preview for redwoodjs-docs canceled. 🔨 Explore the source changes: 4a44530 🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/6234fcb0fc67310008bd8895 |
I could not get this workaround to, well, work on the build:test-project |
@jtoar Confirming that create-redwood-app@canary is working great!! 🚀 |
This PR adds yarn 3 to the create-redwood-app template. This speeds up the
⠏ Running 'yarn install'... (This could take a while)
step significantly.Note that you can still use yarn 1:
create
command too, but we still check for yarn compatibility, so it doesn't work. should we tweak or remove the check for yarn compatibility?