Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cluster id while adding machinepool #1324

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Use cluster id while adding machinepool #1324

merged 2 commits into from
Mar 27, 2024

Conversation

tarukumar
Copy link
Contributor

Observed that we are still using name instead of id while adding machinepool

@tarukumar tarukumar self-assigned this Mar 27, 2024
@tarukumar tarukumar added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Mar 27, 2024
@tarukumar
Copy link
Contributor Author

`[takumar@fedora ods-ci]$ python3 ods_ci/utils/scripts/ocm/ocm.py add_machine_pool --cluster-name qeaisrhods-xyz --worker-node-count 1 --reuse-machine-pool
ods-ci-logger: INFO CMD: ocm list clusters -p search="name = 'qeaisrhods-xyz' or id = 'qeaisrhods-xyz'" --columns id --no-headers

: 2a8lld2m7drto9rj0c6umn9tb4d6f291
ods-ci-logger: INFO CMD: ocm list machinepools --cluster 2a8lld2m7drto9rj0c6umn9tb4d6f291 | grep -w gpunode
ods-ci-logger: INFO CMD: ocm --v=0 create machinepool --cluster 2a8lld2m7drto9rj0c6umn9tb4d6f291 --instance-type g4dn.xlarge --replicas 1 --taints nvidia.com/gpu=NONE:NoSchedule gpunode
`

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
447 0 0 447 100

@tarukumar
remove comment
fef23bb 
Signed-off-by: Tarun Kumar <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@tarukumar tarukumar merged commit 5db9e26 into red-hat-data-services:master Mar 27, 2024
10 of 12 checks passed
@jstourac jstourac mentioned this pull request Mar 27, 2024
Merged
jstourac pushed a commit to jstourac/ods-ci that referenced this pull request Mar 27, 2024
@tarukumar @jstourac
Use cluster id while adding machinepool (red-hat-data-services#1324)
1ef8bb5 
(cherry picked from commit 5db9e26)
jstourac added a commit that referenced this pull request Mar 28, 2024
@jstourac
Backport required changes from master to releases/2.8.0 (#1318)
4088985 
This PR contains following fixes from the `master` branch:

* edafbcc (#1296)
* 5e7f4b1 (#1302)
* b6fb7f7 (#1307)
* 9485246 (#1314)
* abfb8a5 (#1316)
* fc76761 (#1317)
* 439e2b3 (#1306)
* 5db9e26 (#1324)

---

I kept the order in which these commits were merged in the `master`
branch and provided both link to the particular commit and also link to
the particular PR so it's clearer to understand later on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac approved these changes

@apodhrad apodhrad apodhrad approved these changes

Assignees

@tarukumar tarukumar

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarukumar @apodhrad @jstourac