[Fix] cleanup for the dashboard api tests #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleanup only checked for resources of two users but in the tests there are used three different users, so let's clean after all three.
jstourac
added
verified
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ${test_crs}= Create List ${CR_1} ${CR_2} | ||
| FOR ${nb_cr} IN @{test_crs} | ||
| ${present}= Run Keyword And Return Status OpenshiftLibrary.Oc Get kind=Notebook namespace=${NOTEBOOK_NS} name=${nb_cr} | ||
| ${test_usernames}= Create List ${TEST_USER.USERNAME} ${TEST_USER_3.USERNAME} ${TEST_USER_4.USERNAME} |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| ${PVC_BASIC_USER}= Get User Notebook PVC Name ${TEST_USER_3.USERNAME} | ||
| ${PVC_BASIC_USER_2}= Get User Notebook PVC Name ${TEST_USER_4.USERNAME} | ||
| ${test_pvcs}= Create List ${PVC_BASIC_USER} ${PVC_BASIC_USER_2} | ||
| ${test_pvcs}= Create List ${PVC_ADMIN_USER} ${PVC_BASIC_USER} ${PVC_BASIC_USER_2} |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
jiridanek
approved these changes
Mar 25, 2024
Robot Results
|
bdattoma
approved these changes
Mar 25, 2024
jstourac
added a commit
that referenced
this pull request
Mar 28, 2024
This PR contains following fixes from the `master` branch: * edafbcc (#1296) * 5e7f4b1 (#1302) * b6fb7f7 (#1307) * 9485246 (#1314) * abfb8a5 (#1316) * fc76761 (#1317) * 439e2b3 (#1306) * 5db9e26 (#1324) --- I kept the order in which these commits were merged in the `master` branch and provided both link to the particular commit and also link to the particular PR so it's clearer to understand later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup only checked for resources of two users but in the tests there are used three different users, so let's clean after all three.
Note: I'm not aware that this broke any test, but I think we should clean all relevant Notebooks and PVCs after these tests are executed.
After merge, I shall backport to
releases/2.8.0branch too.(results once #1306 is merged also)