Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link to ticket bugs in some tests #1296

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

bdattoma
Copy link
Contributor

No description provided.

@bdattoma bdattoma added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Mar 14, 2024
@bdattoma bdattoma self-assigned this Mar 14, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
448 0 0 448 100

jgarciao
jgarciao previously approved these changes Mar 14, 2024
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add the FlakyTest tag (or ProductBug)

@bdattoma
Copy link
Contributor Author

You might want to add the FlakyTest tag (or ProductBug)

you're right, I forgot about FlakyTest tag.
I'm not adding ProductBug just because these are important tests and would like to avoid skipping their run everytime.

@bdattoma bdattoma requested a review from jgarciao March 14, 2024 16:42
@bdattoma bdattoma force-pushed the add_bug_tags branch 2 times, most recently from 0be04fe to 8b5a6c3 Compare March 18, 2024 08:42
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma bdattoma merged commit edafbcc into red-hat-data-services:master Mar 18, 2024
12 checks passed
@jstourac
Copy link
Member

@bdattoma does this make sense to backport to releases/2.8.0?

@bdattoma
Copy link
Contributor Author

@bdattoma does this make sense to backport to releases/2.8.0?

it could be, nothing against it

jstourac pushed a commit to jstourac/ods-ci that referenced this pull request Mar 27, 2024
* adding link to prod bugs

* add ref to bugs

* add flaky test tags

(cherry picked from commit edafbcc)
jstourac added a commit that referenced this pull request Mar 28, 2024
This PR contains following fixes from the `master` branch:

* edafbcc (#1296)
* 5e7f4b1 (#1302)
* b6fb7f7 (#1307)
* 9485246 (#1314)
* abfb8a5 (#1316)
* fc76761 (#1317)
* 439e2b3 (#1306)
* 5db9e26 (#1324)

---

I kept the order in which these commits were merged in the `master`
branch and provided both link to the particular commit and also link to
the particular PR so it's clearer to understand later on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants