Skip to content

Commit

Permalink
[Fix] capital letters for the particular menu sections
Browse files Browse the repository at this point in the history
These changes are based on this fix into ODH-Dashboard component [1,2].

Note: there is still an inconsistency for `Model Serving` menu item and
relevant page title `Deployed models` which is gonna be handled by [3].

* [1] opendatahub-io/odh-dashboard#2067
* [2] opendatahub-io/odh-dashboard#1907
* [3] opendatahub-io/odh-dashboard#2105
  • Loading branch information
jstourac committed Dec 11, 2023
1 parent b606fd1 commit 40a8067
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 19 deletions.
6 changes: 3 additions & 3 deletions ods_ci/tests/Resources/ODS.robot
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,20 @@ Get "Usage Data Collection" Key

Is Usage Data Collection Enabled
[Documentation] Returns a boolean with the value of configmap odh-segment-key-config > segmentKeyEnabled
... which can be seen also in ODS Dashboard > Cluster Settings > "Usage Data Collection"
... which can be seen also in ODS Dashboard > Cluster settings > "Usage Data Collection"
${usage_data_collection_enabled}= Run
... oc get configmap odh-segment-key-config -n ${APPLICATIONS_NAMESPACE} -o jsonpath='{.data.segmentKeyEnabled}'
${usage_data_collection_enabled}= Convert To Boolean ${usage_data_collection_enabled}
RETURN ${usage_data_collection_enabled}

Usage Data Collection Should Be Enabled
[Documentation] Fails if "Usage Data Collection" is not enabled in ODS Dashboard > Cluster Settings
[Documentation] Fails if "Usage Data Collection" is not enabled in ODS Dashboard > Cluster settings
[Arguments] ${msg}="Usage Data Collection" should be enabled
${enabled}= ODS.Is Usage Data Collection Enabled
Should Be True ${enabled} msg=${msg}

Usage Data Collection Should Not Be Enabled
[Documentation] Fails if "Usage Data Collection" is enabled in ODS Dashboard > Cluster Settings
[Documentation] Fails if "Usage Data Collection" is enabled in ODS Dashboard > Cluster settings
[Arguments] ${msg}="Usage Data Collection" should not be enabled
${enabled}= ODS.Is Usage Data Collection Enabled
Should Not Be True ${enabled} msg=${msg}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Disable Pod Toleration Via UI
Element Should Be Disabled xpath://input[@id="toleration-key-input"]

Save Changes In Cluster Settings
[Documentation] Clicks on the "Save changes" button in Cluster Settings and
[Documentation] Clicks on the "Save changes" button in Cluster settings and
... waits until "Cluster settings changes saved" is shown
Wait Until Page Contains Element xpath://button[.="Save changes"][@aria-disabled="false"] timeout=15s
Click Button Save changes
Expand All @@ -134,7 +134,7 @@ Save Changes In Cluster Settings
Sleep 30s

Enable "Usage Data Collection"
[Documentation] Once in Settings > Cluster Settings, enables "Usage Data Collection"
[Documentation] Once in Settings > Cluster settings, enables "Usage Data Collection"
${is_data_collection_enabled}= Run Keyword And Return Status Checkbox Should Be Selected
... ${USAGE_DATA_COLLECTION_XP}
Set Test Variable ${is_data_collection_enabled} #robocop:disable
Expand All @@ -144,7 +144,7 @@ Enable "Usage Data Collection"
END

Disable "Usage Data Collection"
[Documentation] Once in Settings > Cluster Settings, disables "Usage Data Collection"
[Documentation] Once in Settings > Cluster settings, disables "Usage Data Collection"
${is_data_collection_enabled}= Run Keyword And Return Status Checkbox Should Be Selected
... ${USAGE_DATA_COLLECTION_XP}
Set Test Variable ${is_data_collection_enabled} #robocop:disable
Expand Down Expand Up @@ -220,13 +220,13 @@ Open Dashboard Settings
END
Click Element xpath://a[.="${settings_page}"]
IF "${settings_page}" == "Notebook images"
${exp_page_title}= Set Variable Notebook images settings
${exp_page_title}= Set Variable Notebook image settings
ELSE IF "${settings_page}" == "Cluster settings"
${exp_page_title}= Set Variable Cluster Settings
${exp_page_title}= Set Variable Cluster settings
ELSE IF "${settings_page}" == "Serving runtimes"
${exp_page_title}= Set Variable Serving runtimes
ELSE IF "${settings_page}" == "User management"
${exp_page_title}= Set Variable User and group settings
${exp_page_title}= Set Variable User management
END
Wait For RHODS Dashboard To Load expected_page=${exp_page_title}
... wait_for_cards=${FALSE}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Resource ./Workbenches.resource


*** Variables ***
${DS_PROJECT_XP}= xpath=//h1[text()="Data science projects"]
${DS_PROJECT_XP}= xpath=//h1[text()="Data Science Projects"]
${TITLE_INPUT_XP}= xpath=//input[@id="manage-project-modal-name"]
${DESCR_INPUT_XP}= xpath=//textarea[@id="manage-project-modal-description"]
${RESOURCE_INPUT_XP}= xpath=//input[@id="resource-manage-project-modal-name"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Library ../../../../../libs/Helpers.py


*** Variables ***
${MS_HEADER_XP}= xpath=//h1[text()="Model serving"]
${MS_HEADER_XP}= xpath=//h1[text()="Model Serving"]
${S3_NAME_DC_INPUT_XP}= xpath=//input[@aria-label="Field list Name"]
${S3_KEY_DC_INPUT_XP}= xpath=//input[@aria-label="Field list AWS_ACCESS_KEY_ID"]
${S3_SECRET_DC_INPUT_XP}= xpath=//input[@aria-label="Field list AWS_SECRET_ACCESS_KEY"]
Expand All @@ -31,7 +31,7 @@ Open Model Serving Home Page
[Documentation] Verifies submenu Settings > "Model Serving" is visible and navigates to page
Page Should Contain Model Serving
Click Link Model Serving
# Replace sleep with better Wait keyword. Confirm if error page has "Model serving" h1 element.
# Replace sleep with better Wait keyword. Confirm if error page has "Model Serving" h1 element.
Sleep 1s
${loading_error} = Run Keyword And Return Status Page Should Contain Problem loading model serving page
IF ${loading_error}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Clean Up DSP Page
END
Delete Data Science Projects From CLI ${projects}
Reload Page
Wait Until Page Contains Data science projects
Wait Until Page Contains Data Science Projects
END

Verify Openvino Deployment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Verify That Not Admin Users Can Not Access "Cluster Settings"
[Teardown] Dashboard Settings Test Teardown

Verify That "Usage Data Collection" Can Be Set In "Cluster Settings"
[Documentation] Verifies that a user can set the "Usage Data Collection" flag in "Cluster Settings"
[Documentation] Verifies that a user can set the "Usage Data Collection" flag in "Cluster settings"
[Tags] Tier1
... Sanity
... ODS-1218
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ${PV_SIZE}= 1
*** Test Cases ***
Verify Notebook Tolerations Are Applied To Workbenches
[Documentation] Verifies workbenches get the custom tolerations set by
... admins in "Cluster Settings" page. It checks 3 scenarios:
... admins in "Cluster settings" page. It checks 3 scenarios:
... -tolerations changes applied to workbench created after the changes (value from null to A)
... -tolerations change applied to existent workbench, after restart (value from null to A)
... -tolerations change applied to existent workbench, after restart (value from A to A)
Expand Down Expand Up @@ -286,15 +286,15 @@ Check Limits And Requests For Every Workbench Pod Container
END

Open Settings And Set Tolerations To
[Documentation] Opens the "Cluster Settings" page in RHODS Dashboard
[Documentation] Opens the "Cluster settings" page in RHODS Dashboard
... and set the tolerations settings to the given one
[Arguments] ${tolerations_text}
Open Dashboard Settings settings_page=Cluster settings
Set Pod Toleration Via UI ${tolerations_text}
Save Changes In Cluster Settings

Open Settings And Disable Tolerations
[Documentation] Opens the "Cluster Settings" page in RHODS Dashboard
[Documentation] Opens the "Cluster settings" page in RHODS Dashboard
... and disable the tolerations settings.
... Before disabling the setting, it restores the default value
Open Dashboard Settings settings_page=Cluster settings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ Clean Up DSP Page
END
Delete Data Science Projects From CLI ${projects}
Reload Page
Wait Until Page Contains Data science projects
Wait Until Page Contains Data Science Projects
END

Try Opening Create Server
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ Clean Up DSP Page
END
Delete Data Science Projects From CLI ${projects}
Reload Page
Wait Until Page Contains Data science projects
Wait Until Page Contains Data Science Projects
END

Try Opening Create Server
Expand Down

0 comments on commit 40a8067

Please sign in to comment.