Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story]: Fix inconsistent header in Global Model Serving view #2105

Closed
lucferbux opened this issue Nov 8, 2023 · 2 comments
Closed

[Story]: Fix inconsistent header in Global Model Serving view #2105

lucferbux opened this issue Nov 8, 2023 · 2 comments
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@lucferbux
Copy link
Contributor

Goal

Fix inconsistent header in Global Model Serving view

Dependency issue

No dependencies

Itemized goals

  • Right now, we have "Deployed models" as the header in the Model Serving Global view
  • The header should be all Upper Case
  • But we should have the same content in the nav link (which currently has Model Serving as the value)
  • We need to fix the inconsistency and find the right title

Aspects continued elsewhere

No response

Mocks
@lucferbux lucferbux added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Nov 8, 2023
@lucferbux lucferbux mentioned this issue Nov 8, 2023
Closed
@lucferbux lucferbux moved this from Untriaged to Dev To do in ODH Dashboard Planning Nov 8, 2023
@lucferbux lucferbux self-assigned this Nov 15, 2023
@lucferbux lucferbux mentioned this issue Nov 16, 2023
Closed
@lucferbux lucferbux moved this from Dev To do to Dev In progress in ODH Dashboard Planning Nov 20, 2023
@lucferbux lucferbux removed their assignment Nov 20, 2023
@lucferbux
Copy link
Contributor Author

@vconzola We still have this opened, it would be great to unblock it in the future

@jstourac jstourac mentioned this issue Dec 7, 2023
Closed
1 task
@jstourac jstourac mentioned this issue Dec 7, 2023
Merged
@dgutride
Copy link
Contributor

dgutride commented Dec 8, 2023

Migrated to: https://issues.redhat.com/browse/RHOAIENG-551

@dgutride dgutride closed this as completed Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Dec 8, 2023
jstourac added a commit to jstourac/ods-ci that referenced this issue Dec 10, 2023
@jstourac
[Fix] capital letters for the particular menu sections
1b90301 
These changes are based on this fix into ODH-Dashboard component [1,2].

Note: there is still an inconsistency for `Model Serving` menu item and
relevant page title `Deployed models` which is gonna be handled by [3].

* [1] opendatahub-io/odh-dashboard#2067
* [2] opendatahub-io/odh-dashboard#1907
* [3] opendatahub-io/odh-dashboard#2105
jstourac added a commit to red-hat-data-services/ods-ci that referenced this issue Dec 11, 2023
@jstourac
[Fix] capital letters for the particular menu sections
40a8067 
These changes are based on this fix into ODH-Dashboard component [1,2].

Note: there is still an inconsistency for `Model Serving` menu item and
relevant page title `Deployed models` which is gonna be handled by [3].

* [1] opendatahub-io/odh-dashboard#2067
* [2] opendatahub-io/odh-dashboard#1907
* [3] opendatahub-io/odh-dashboard#2105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgutride @lucferbux