-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page title sentence casing #2067
Fix page title sentence casing #2067
Conversation
🎉🎉🎉🎉 |
@dgutride the template asks for you to tag a UX person if there are UI changes... but in this case there is already a UX decision made... but we should always reping them to make sure we delivered on their ask. Lucas tagged Katie. |
Also @dgutride ... From a scan of the code, you're missing Model Serving. I'm spinning up a Cluster Bot cluster to make sure I can get a state in there somehow to see the page. Looks like Model Serving is having some issues on our shared cluster. |
|
2ddd4e9
to
c3855c8
Compare
@andrewballantyne Breadcrumbs should match the casing of the navigation item and the project/item's casing - so "Data Science Projects > Andrew's test" (If that's how the project name is capitalized) |
@dgutride there is another fix you need to do -- there are a few breadcrumb values that need to be updated as well to fit the page naming. There are two "Data science projects" items for breadcrumbs that need to be updated and I think actually there is one for Data Science Pipelines that I just called "Projects" which needs to be updated too. If you search for these things you should be able to find all 3 easily:
|
c3855c8
to
4cb4d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... We have some bugs in the way Pipelines references items inside a project vs the global page, but that's definitely separate of this initiative. I'll look to log something soon.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes are based on this fix into ODH-Dashboard component [1,2]. Note: there is still an inconsistency for `Model Serving` menu item and relevant page title `Deployed models` which is gonna be handled by [3]. * [1] opendatahub-io/odh-dashboard#2067 * [2] opendatahub-io/odh-dashboard#1907 * [3] opendatahub-io/odh-dashboard#2105
These changes are based on this fix into ODH-Dashboard component [1,2]. Note: there is still an inconsistency for `Model Serving` menu item and relevant page title `Deployed models` which is gonna be handled by [3]. * [1] opendatahub-io/odh-dashboard#2067 * [2] opendatahub-io/odh-dashboard#1907 * [3] opendatahub-io/odh-dashboard#2105
Description
Changed three page titles to match the navigation item casing. Top level items should be Title Case, all nested items should be Sentence case.
Cluster settings (was Cluster Settings), User management (instead of User and group settings) and Data Science Projects (instead of Data science projects since it's a top level item) were all changed.
How Has This Been Tested?
Ran the site locally, loaded all impacted pages and ensured that the page title now matches the navigation item on the left hand side.
Test Impact
Ran storybook and other tests before putting up PR - none needed adjustment.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
Closes: #1907