Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure global roles are listed in a consistent order #11306

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Ensure global roles are listed in a consistent order #11306

merged 1 commit into from
Jul 1, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jun 27, 2024 •
edited
Loading

Summary

Fixes #11013

This PR fixes the above issue - it applies a sort so that the global permissions are always listed in this order:

Administrator
Restricted Admin
Standard user
User base

Areas or cases that should be tested

An automated test is included.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac requested review from richard-cox and aalves08 June 27, 2024 10:38
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.9.0 milestone Jun 27, 2024
aalves08
aalves08 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nwmac

Screenshot 2024-07-01 at 09 44 41 Screenshot 2024-07-01 at 09 44 37

@nwmac nwmac merged commit ba76ad7 into rancher:master Jul 1, 2024
34 checks passed
@nwmac nwmac deleted the fix-global-roles-order branch July 1, 2024 08:50
@aalves08 aalves08 mentioned this pull request Jul 24, 2024
Closed
nwmac added a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
@nwmac
Ensure global roles are listed in a consistent order (rancher#11306)
62879bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

@richard-cox richard-cox Awaiting requested review from richard-cox

Assignees

@nwmac nwmac

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

Global permissions on UI are in a random order
2 participants
@nwmac @aalves08