Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global permissions on UI are in a random order #11013

Closed
github-actions bot opened this issue May 13, 2024 · 7 comments · Fixed by #11306
Closed

Global permissions on UI are in a random order #11013

github-actions bot opened this issue May 13, 2024 · 7 comments · Fixed by #11306
Assignees
Labels
area/rbac kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@github-actions
Copy link
Contributor

This is a forwardport issue for #11010, automatically created via GitHub Actions workflow initiated by @richard-cox

Original issue body:

Setup

  • Rancher version: v2.7.13-rc4
  • Rancher UI Extensions: release-2.7 d14964b0d
  • Browser type & version: Chrome

Describe the bug
Global permissions on the Users and authentication page, have the permissions in a different order.

To Reproduce

  1. Install rancher 2.7.13-rc4
  2. Navigate to users and authentication >> Users
  3. Create a user
  4. Notice the order of the global permissions

Result

Restricted Admin
User base
Administrator
Standard user

Expected Result
Expected the order to be:

Administrator
Restricted Admin
Standard user
User base

Screenshots
2024-05-10_16-43-26

Additional context:
Do not see the issue on v2.7.12

@github-actions github-actions bot added area/user kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None status/release-blocker labels May 13, 2024
@github-actions github-actions bot added this to the v2.9.0 milestone May 13, 2024
@nwmac
Copy link
Member

nwmac commented May 29, 2024

@richard-cox I have brought up a fresh 2.9 and the permissions order seems correct to me:

image

@richard-cox
Copy link
Member

It looks like we rely on the order provided in the API response to glovalroles. Sometimes this is correct, sometimes not

https://github.com/rancher/dashboard/blob/master/shell/components/GlobalRoleBindings.vue#L54-L68

image

@nwmac
Copy link
Member

nwmac commented May 29, 2024

So should we sort them alphabetically, or hard code an order for the ones we want in that order and show any others below?

@richard-cox
Copy link
Member

Would vote we hard code the order, but still only show the ones the user can see (aka exist in the globalroles response). Not sure they'll ever not be able to see them all but just in case

@gaktive
Copy link
Member

gaktive commented Jun 19, 2024

Assigning to @rak-phillip in case that PR does tackle this ticket, which could then move to Working or later.

@rak-phillip
Copy link
Member

@gaktive I think this issue number inadvertently got pulled in with the forward porting effort for user retention. Removing the link from the PR.

@nwmac nwmac changed the title [forwardport v2.9.0] Global permissions on UI are in a random order Global permissions on UI are in a random order Jun 27, 2024
@nwmac nwmac added area/rbac and removed area/user labels Jun 27, 2024
@nwmac nwmac self-assigned this Jun 27, 2024
@nwmac nwmac added the size/1 Size Estimate 1 label Jun 27, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot added size/1 Size Estimate 1 and removed size/1 Size Estimate 1 labels Jun 27, 2024
@yonasberhe23
Copy link
Contributor

e2e test is sufficient! moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rbac kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants