Added WinRT (Windows 8) compatible library, sharing code where possible #66
Conversation
…patibility with future .NET framework changes (all non-desktop frameworks).
Includes NUnit driven tests. Also includes Windows Store example application. Addresses GitHub issue #16
|
@ngbrown I'm now getting What do I have to configure to get rid of it? |
|
@michaelklishin, I get the same errors with your changes. Bisecting back to a7f371b, the merge, it doesn't have the problem. |
|
@ngbrown yes, it was a confusing error message, the problem was unrelated to the target. However, I still could not make the solution build without re-targeting. I have Windows 8 SDK installed, tried rebooting, inspecting project files manually, and so on. We'll go with VS 2013 CE and Windows 8.1 as a requirement for now. RabbitMQ 3.6.0 will ship in September-October. If Windows 8 support is a big enough deal, we can revisit this decision later. |
|
Building on Mono works now. Windows 7 doesn't seem to be an option for building Windows Store apps, so I'll have to test that WinRT is properly disabled in the build system there. Otherwise this seems to be ready to merge. |
|
@michaelklishin With the most recent changes you've pushed, More seriously, even though it compiles, RabbitMQ.Client.Examples.WinRT.Subscriber no longer deploys and launches. It is not building the AppX container. Is there any way that the build process can specify the target projects to include or exclude instead of these conditionals in the individual |
|
We can look into adding some Make targets that perform platform-specific builds a bit later. I'll investigate what's up with the project files. |
michaelklishin
force-pushed
the
rabbitmq-dotnet-client-65
branch
from
f120364 to
2c0308d
Compare
|
@ngbrown I've started from your revision. Re-targeted for 8.1, getting when I try to deploy the WinRT example project. My goal is to make sure Windows stuff work first, then add condtions for Mono. |
|
@michaelklishin I see that you changed RabbitMQ.Client.Unit.WinRT.csproj to link to the non-winrt client. See 3489419 for the minimum changes for a re-target to win 8.1. |
|
@michaelklishin, you mentioned the Windows 8 SDK, did you install it with the maintenance screen from the Visual Studio 2013 ISO/Installer? This is all I have to enable this on my Windows 8.1 computer: "Tools for Maintaining Store Apps for Windows 8". I don't have Visual Studio 2012. Another possibility would be to close the solution (and make sure the example client .exe is killed) and run |
|
I have both Tools for Maintaining Store Apps for Windows 8 and Windows Phone 8.0 SDK installed. |
|
Uninstalling Windows Phone 8.0 SDK didn't help. I ended up symlinking Attempts to deploy the example app now fail with |
|
See the comments to the answer here: http://stackoverflow.com/a/13163076/25182 This is a known cygwin issue. |
|
Changing build output directory to a random directory outside of Cygin's home indeed helps. The app deploys successfully. I'm not sure how to run it in the emulator but looks like Windows is good and we can move on to Mono. |
michaelklishin
force-pushed
the
rabbitmq-dotnet-client-65
branch
from
2c0308d to
a3f8b74
Compare
|
After an IRC discussion and multiple resets we have retained Windows 8.0 compatibility. Excluding Mono is also done, need to investigate why msbuild.exe fails to build from scratch while VS doesn't. |
|
RabbitMQ.Client.Unit.WinRT fails to build with |
Having stub targets trips up msbuild
|
@ngbrown OK, now things build in VS, with msbuild.exe and xbuild on Mono. Unit.WinRT passes all tests. I'm ready to merge as soon as you confirm that things work for you just as well and the example app deploys and runs. |
Added WinRT (Windows 8) compatible library, sharing code where possible
|
I felt confident (and excited) enough to merge. |
Change Build,Rebuild,Clean Target behavior through changing DependsOn properties instead of replacing Targets.
Change Build,Rebuild,Clean Target behavior through changing DependsOn properties instead of replacing Targets.
Fixes issue with closed merge #66
This is #65 by @ngbrown, re-submitted to follow our branch naming convention. I intend to push a few build system fixes to disable building WinRT client on Mono and make it possible to disable it on Windows, e.g. versions prior to 8.
effort-highbecause this is a substantial contribution (my contribution iseffort-tiny).