Added WinRT (Windows 8) compatible library, sharing code where possible. #65
Conversation
…patibility with future .NET framework changes (all non-desktop frameworks).
Includes NUnit driven tests. Also includes Windows Store example application. Addresses GitHub issue rabbitmq#16
|
Thank you. I've noticed that on my development machine (Windows 8.1, VS 2013 Community edition), the location of instead of I'll update the project file for 8.1/VS 2013 CE but we may want to investigate making this work on different versions. |
|
This clearly wasn't tested on Mono. Fails to build because build files in the WinRT projects have no conditions. |
|
Since it is a non-gui library, there's not a lot of benefit to target netcore451 (win 8.1). This current way it is compatible with both 8 and 8.1. There is an option in the Visual Studio 2013 installer to install the libraries and tools to maintain Windows 8 apps. You will need to run the installer in maintenance mode and check it. If the library is upgraded, then the nuspec file needs changed as well. |
|
Yes, I now see that VS needs to install some additional tools. Investigating. |
|
I don't have a Linux or Mono environment and don't know what is needed. |
|
I'll take care of Mono. @ngbrown I've invited you to the .NET client contributors team. I'll soon close this PR and push a branch that has some project file modifications (primarily related to Mono). We'll use that branch to make sure things build (or are skipped) in all our environments, then merge. If you haven't already, please sign our contributor agreement document and send it to me. |
|
You should have my signed contribution agreement on file. Let me know if I need to resend it. |
|
Perfect. Then I'll push a branch ( Thank you, this is a substantial contribution and easily one of the biggest bullet points for the 3.6.0 release notes. |
|
Closing in favour of #66. |
Includes NUnit driven tests.
Includes Windows Store example application.
Includes netcore45 addition to NuGet nuspec file.
Addresses GitHub issue #16.
The work I did toward #32 with a public CI ran into some troubles with WinRT Tasks usage and the single CPU test environment. Some unit tests work fine on multi-processor environment, but deadlock on a single CPU core environment (can be simulated with CPU affinity). I think by pushing this to the main branch, more people can work on this and it can be figured out.