Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with closed merge #66 #67

Merged
merged 1 commit into from
Apr 22, 2015

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Apr 22, 2015

Change Build,Rebuild,Clean Target behavior through changing DependsOn properties instead of replacing Targets.

@michaelklishin Can you check out that this works with Mono?

Change Build,Rebuild,Clean Target behavior through changing DependsOn properties instead of replacing Targets.
@ngbrown ngbrown force-pushed the rabbitmq-dotnet-client-16 branch from a3af26a to 02f4940 Compare April 22, 2015 03:22
@michaelklishin
Copy link
Member

This is a good idea. I'll merge and add the necessary conditionals. I'm also open to considering not supporting solution-wide builds on Mono because we only care about the "regular" client, ApiGen, and .NET test suite working there.

michaelklishin added a commit that referenced this pull request Apr 22, 2015
@michaelklishin michaelklishin merged commit 652f1c9 into rabbitmq:master Apr 22, 2015
@michaelklishin
Copy link
Member

@ngbrown it does seem to work well for Mono/xbuild. We're looking into our nightly builds, otherwise I'm OK with keeping the build system as is in master.

Thank you!

@michaelklishin
Copy link
Member

Unfortunately this does not work on Windows 7.

@dumbbell dumbbell added this to the 3.6.0 milestone May 6, 2015
@ngbrown ngbrown deleted the rabbitmq-dotnet-client-16 branch March 11, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants