-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help find and troubleshoot pprof installation #15
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
- Coverage 46.42% 42.52% -3.9%
=========================================
Files 3 4 +1
Lines 56 87 +31
=========================================
+ Hits 26 37 +11
- Misses 30 50 +20
Continue to review full report at Codecov.
|
@krlmlr, what do you think about these new functions for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
We can simplify the Windows installation a bit if we look at default locations for the executables if they're not on the $PATH
. This seems possible for Go and doesn't look too difficult for Graphviz. Also, we could provide an installation helper that installs {RProtoBuf} and directs the user to installers for Windows, or tells which packages to install on Linux and macOS.
I'll take a stab.
Co-Authored-By: Kirill Müller <[email protected]>
Co-Authored-By: Kirill Müller <[email protected]>
Summary
To address #13 and #14, this PR exports 3 functions:
pprof_path()
: return the path topprof
if it exists and""
otherwise.assert_pprof()
: error ifpprof
is not found.test_pprof()
: tests thepprof()
function on a small example to make sure thepprof
installation is usable.By default, each function prints console messages whenever it struggles to find
pprof
. Setverbose = FALSE
to turn these messages off.Related GitHub issues and pull requests
Checklist
proffer
's code of conduct.testthat
unit tests totests/testthat
for any new functionality. Feel free to useskip("interactive only")
for any tests that cannot be fully automated.