Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing pprof installation? #14

Closed
2 tasks done
wlandau opened this issue Feb 6, 2020 · 1 comment
Closed
2 tasks done

Use existing pprof installation? #14

wlandau opened this issue Feb 6, 2020 · 1 comment
Labels
topic: dependencies

Comments

@wlandau
Copy link
Member

wlandau commented Feb 6, 2020

Prework

Description

From @krlmlr: if pprof is already installed, maybe proffer should try to find it (borrowing from jointprof::find_pprof()) instead of always relying on the pprof_path environment variable.
wlandau-lilly added a commit that referenced this issue Feb 6, 2020
@wlandau-lilly
Address #13 and #14
0c5dceb
@wlandau wlandau mentioned this issue Feb 6, 2020
Merged
4 tasks
@wlandau
Copy link
Member Author

wlandau commented Feb 25, 2020

Fixed in #15. Can be streamlined going forward though.

@wlandau wlandau closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wlandau