Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling family groups #281

Closed
asztalosdani opened this issue Mar 5, 2018 · 3 comments · Fixed by #304
Closed

Toggling family groups #281

asztalosdani opened this issue Mar 5, 2018 · 3 comments · Fixed by #304

Comments

@asztalosdani
Copy link

Description

Clicking on the family gives unexpected results. See attached gif.
pyblish_qml

Expected result

  1. The group should only uncheck instances if all of them are checked, and check all unchecked ones.
  2. Or a proper tri-state checkbox could be implemented.

How to reproduce

import pyblish.api
class ACollector(pyblish.api.ContextPlugin):
    order = pyblish.api.CollectorOrder - 0.1
    def process(self, context):
        context.create_instance("A instance", family="family")
        context.create_instance("B instance", family="family")
        
pyblish.api.register_plugin(ACollector)
  1. Uncheck an instance.
  2. Click the family -> the unchecked instance is checked.
  3. Uncheck both instances.
  4. Click the family -> nothing happens
  5. Check both instances.
  6. Click the family -> nothing happens
@mottosso
Copy link
Member

mottosso commented Mar 5, 2018

Thanks for these detailed reports, @asztalosdani.

I'm also noticing there is a missing icon on the Pyblish window, any idea what that could be?

@asztalosdani
Copy link
Author

asztalosdani commented Mar 5, 2018

I'm also noticing there is a missing icon on the Pyblish window, any idea what that could be?

No, not yet. The icon file is there, and pyblish_qml is reading it from the correct place.

@davidlatwe
Copy link
Collaborator

I have fixed this one on my end, will send the PR after community made the decision to accept #303 or not, for conflict avoiding.

davidlatwe added a commit to davidlatwe/pyblish-qml that referenced this issue Oct 1, 2018
mottosso added a commit that referenced this issue Oct 2, 2018
@davidlatwe davidlatwe mentioned this issue Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants