Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling family groups does not respect mandatory Instances #309

Closed
darkvertex opened this issue Nov 2, 2018 · 3 comments · Fixed by #314
Closed

Toggling family groups does not respect mandatory Instances #309

darkvertex opened this issue Nov 2, 2018 · 3 comments · Fixed by #314
Assignees
@davidlatwe
Labels
bug

Comments

@darkvertex
Copy link
Contributor

I discovered that the feature introduced by #281 does not respect whether any of the instances in that group have .data['optional'] set to False, ie "mandatory" or "non-optional" instances, which I had introduced support for as of version 1.7.4.

Toggling should not fail, but it should skip the non-optional Instances from being toggled.
@mottosso mottosso added the bug label Nov 2, 2018
@mottosso
Copy link
Member

mottosso commented Nov 2, 2018

Thanks for reporting this @darkvertex

@davidlatwe davidlatwe self-assigned this Dec 28, 2018
@davidlatwe
Copy link
Collaborator

I have got this solved on my end, will make a PR after the version 1.9.0 is out !

davidlatwe added a commit to davidlatwe/pyblish-qml that referenced this issue Dec 28, 2018
@davidlatwe
Fix pyblish#309
2d1df3c
davidlatwe added a commit to davidlatwe/pyblish-qml that referenced this issue Jan 9, 2019
@davidlatwe
Fix pyblish#309
a3bd01c
davidlatwe added a commit to davidlatwe/pyblish-qml that referenced this issue Jan 9, 2019
@davidlatwe
Fix pyblish#309
01e9605
davidlatwe added a commit to davidlatwe/pyblish-qml that referenced this issue Jan 9, 2019
@davidlatwe
Fix pyblish#309
c5c2d19
@davidlatwe davidlatwe mentioned this issue Jan 13, 2019
Merged
@darkvertex
Copy link
Contributor Author

Thanks for fixing this, @davidlatwe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlatwe davidlatwe

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 309 davidlatwe/pyblish-qml
3 participants
@darkvertex @mottosso @davidlatwe