Enhancement, fix #281, #274 and #119 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intentional. The instances are displayed in the order they are processed, and it's a feature of Pyblish to be able to arrange (and re-arrange) the instance order inside the context. class MyCollector(...):
...
def process(self, context):
context[:] = sorted(context, key=lambda i: i.data["someKey"]) |
This reverts commit 5e7042b.
|
:O sorry, didn't know that ! Will update those gif later :) |
|
Comment updated. GIF replaced and the PR description also renewed. |
|
Loving it! Welcome to merge and release once you're happy :) |
|
This is great stuff David! |
BigRoy
approved these changes
Oct 2, 2018
davidlatwe
added a commit
to davidlatwe/pyblish-qml
that referenced
this pull request
Oct 2, 2018
davidlatwe
added a commit
that referenced
this pull request
Oct 6, 2018
Fix #304, increase QML initialization waiting time
davidlatwe
added a commit
to davidlatwe/pyblish-qml
that referenced
this pull request
Oct 7, 2018
davidlatwe
added a commit
to davidlatwe/pyblish-qml
that referenced
this pull request
Oct 7, 2018
User operation will not be able to continue if the validation failed during the publish, since the logic to interrupt publish when validation failed is taking place in the beginning of extraction. In the state machine, `extracting` state will need to transition to `finished` when the validation failed, and since it's not able to do so, operation can't continue, due to the stop button didn't change to reset button. This commit fixed that.
davidlatwe
added a commit
that referenced
this pull request
Oct 9, 2018
Fix state machine transision bug from PR #304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide 2 fix and 1 extra feature:
Before
After