Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the sidecar for gathering facts #213

Closed
glennsarti opened this issue Jan 14, 2020 · 0 comments · Fixed by #215
Closed

Use the sidecar for gathering facts #213

glennsarti opened this issue Jan 14, 2020 · 0 comments · Fixed by #215

Comments

@glennsarti
Copy link
Contributor

Currently the node facts are evaluated in the Editor Service which makes it difficult to modify the module path etc. to find facts in the workspace.

This issue will track the work to refactor the fact gathering to use the Sidecar which has the requisite workspace injection.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 14, 2020
@glennsarti
(puppetlabsGH-213) Gather facts using the Sidecar
82f768b 
Previously the facts where evaluated only within the Editor Service process
however this meant the workspace couldn't be injected.  This commit adds a new
action to the Sidecar process to evaluate the facts. The Sidecar has the
required monkey patches to inject the workspace into the fact search
directories.

This commit also adds tests and fixtures to ensure that custom and external
facts can be resolved.
@glennsarti glennsarti mentioned this issue Jan 14, 2020
Merged
jpogran added a commit that referenced this issue Jan 17, 2020
@jpogran
Merge pull request #214 from glennsarti/refactor-factor
590804e 
(GH-213) Gather facts using the Sidecar
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 21, 2020
@glennsarti
(puppetlabsGH-213) Update Facts sidecar protocol
3bb1024 
Previously in commit 590804e the Sidecar was updated to retrieve facts
however the object module was incorrectly setup to be used by the Language
Server in-memory cache. This commit changes the protocol to have a Fact and
FactList, similar to PuppetClass etc.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 21, 2020
@glennsarti
(puppetlabsGH-213) Use Facts from the Sidecar
4240883 
Now that facts can be loaded from the Sidecar, the FacterHelper needs to be
updated to use these instead of calling Facter directly.  This commit:

* Modifies the FacterHelper to call the sidecar queue to get the Fact
  information
* Modifies the FacterHelper to expose methods to query facts
* Updates the cache to store facts
* Updates the tests for the new Fact collection method
@glennsarti glennsarti mentioned this issue Jan 21, 2020
Merged
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 21, 2020
@glennsarti
(puppetlabsGH-213) Update Facts sidecar protocol
2bf5940 
Previously in commit 590804e the Sidecar was updated to retrieve facts
however the object module was incorrectly setup to be used by the Language
Server in-memory cache. This commit changes the protocol to have a Fact and
FactList, similar to PuppetClass etc.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 21, 2020
@glennsarti
(puppetlabsGH-213) Use Facts from the Sidecar
a8c5e1f 
Now that facts can be loaded from the Sidecar, the FacterHelper needs to be
updated to use these instead of calling Facter directly.  This commit:

* Modifies the FacterHelper to call the sidecar queue to get the Fact
  information
* Modifies the FacterHelper to expose methods to query facts
* Updates the cache to store facts
* Updates the tests for the new Fact collection method
jpogran added a commit that referenced this issue Jan 22, 2020
@jpogran
Merge pull request #215 from glennsarti/gh-213-use-fact-sidecar
131c2ea 
(GH-213) Use Facts from the Sidecar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-213) Use Facts from the Sidecar glennsarti/puppet-editor-services
1 participant
@glennsarti