(GH-213) Use Facts from the Sidecar #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
changed the title
Previously in commit 590804e the Sidecar was updated to retrieve facts however the object module was incorrectly setup to be used by the Language Server in-memory cache. This commit changes the protocol to have a Fact and FactList, similar to PuppetClass etc.
Now that facts can be loaded from the Sidecar, the FacterHelper needs to be updated to use these instead of calling Facter directly. This commit: * Modifies the FacterHelper to call the sidecar queue to get the Fact information * Modifies the FacterHelper to expose methods to query facts * Updates the cache to store facts * Updates the tests for the new Fact collection method
glennsarti
force-pushed
the
gh-213-use-fact-sidecar
branch
from
4240883 to
a8c5e1f
Compare
jpogran
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
#213 Part 2
Previously in commit 590804e the Sidecar was updated to retrieve facts
however the object module was incorrectly setup to be used by the Language
Server in-memory cache. This commit changes the protocol to have a Fact and
FactList, similar to PuppetClass etc.
Now that facts can be loaded from the Sidecar, the FacterHelper needs to be
updated to use these instead of calling Facter directly. This commit:
information