(GH-213) Gather facts using the Sidecar #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the facts where evaluated only within the Editor Service process however this meant the workspace couldn't be injected. This commit adds a new action to the Sidecar process to evaluate the facts. The Sidecar has the required monkey patches to inject the workspace into the fact search directories. This commit also adds tests and fixtures to ensure that custom and external facts can be resolved.
jpogran
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of #213 . Part2 will contain the work to actually use the sidecar to get the facts.
Previously the facts where evaluated only within the Editor Service process
however this meant the workspace couldn't be injected. This commit adds a new
action to the Sidecar process to evaluate the facts. The Sidecar has the
required monkey patches to inject the workspace into the fact search
directories.
This commit also adds tests and fixtures to ensure that custom and external
facts can be resolved.