Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks in CI and provide results in PR comment #75

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Run benchmarks in CI and provide results in PR comment #75

merged 1 commit into from
Jan 10, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jan 9, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

@simu simu force-pushed the feat/bench-results-in-pr branch 2 times, most recently from 9e898bb to 047fed9 Compare January 9, 2024 16:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Benchmark for 591cde7

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1548.6±109.73µs 1556.4±115.07µs +0.50%
Reclass::inventory() single-threaded 3.5±0.03ms 3.5±0.08ms 0.00%

@projectsyn projectsyn deleted a comment from github-actions bot Jan 9, 2024
@projectsyn projectsyn deleted a comment from github-actions bot Jan 9, 2024
@simu simu mentioned this pull request Jan 10, 2024
Merged
4 tasks
@simu simu added the internal label Jan 10, 2024
Base automatically changed from feat/bench-inventory to main January 10, 2024 09:28
@simu simu force-pushed the feat/bench-results-in-pr branch from 047fed9 to b870bee Compare January 10, 2024 09:28
@simu simu marked this pull request as ready for review January 10, 2024 09:28
@github-actions GitHub Actions
Copy link

Benchmark for d6fa86e

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1553.8±117.85µs 1559.3±111.93µs +0.35%
Reclass::inventory() single-threaded 3.4±0.05ms 3.4±0.04ms 0.00%

@simu simu requested a review from a team January 10, 2024 09:36
@simu simu merged commit 77f3833 into main Jan 10, 2024
18 checks passed
@simu simu deleted the feat/bench-results-in-pr branch January 10, 2024 10:24
@simu simu mentioned this pull request Jan 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebakelOrakel DebakelOrakel DebakelOrakel approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simu @DebakelOrakel